Issue 466763002: AudioNode::breakConnectionWithLock() doesn't need to check 'm_normalRefCount > 1' in non-oilpan bui…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466763002: AudioNode::breakConnectionWithLock() doesn't need to check 'm_normalRefCount > 1' in non-oilpan bui… (Closed)

Created:
6 years, 4 months ago by haraken

Modified:
6 years, 4 months ago

Reviewers:
oilpan-reviews, tkent

CC:
blink-reviews, Raymond Toy

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

AudioNode::breakConnectionWithLock() doesn't need to check 'm_normalRefCount > 1' in non-oilpan builds This check was introduced in https://codereview.chromium.org/386403002/. I agree that it's OK to have the check, but the check is not needed. If we have the check, we can avoid the overhead of calling disableOutputsIfNecessary() when the AudioNode is about to die. However, having the check causes an issue when rewriting the reference counting system (see full CL: https://codereview.chromium.org/438293003/), I remove the check in this CL in preparation for the rewrite. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180233

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	Source/modules/webaudio/AudioNode.cpp	View		1 chunk	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/466763002/1

6 years, 4 months ago (2014-08-14 02:41:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180233

Expand Messages | Collapse Messages