Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1981)

Unified Diff: Source/modules/webaudio/AudioNode.cpp

Issue 466763002: AudioNode::breakConnectionWithLock() doesn't need to check 'm_normalRefCount > 1' in non-oilpan bui… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioNode.cpp
diff --git a/Source/modules/webaudio/AudioNode.cpp b/Source/modules/webaudio/AudioNode.cpp
index f325bee4b7fe0be99a585a1d78a51af7652f371f..1c5a36948c400e23a59a0449465a632e94fbfbb1 100644
--- a/Source/modules/webaudio/AudioNode.cpp
+++ b/Source/modules/webaudio/AudioNode.cpp
@@ -586,16 +586,12 @@ void AudioNode::breakConnection()
void AudioNode::breakConnectionWithLock()
{
-#if ENABLE(OILPAN)
atomicDecrement(&m_connectionRefCount);
- if (m_connectionRefCount == 0)
- disableOutputsIfNecessary();
-#else
+#if !ENABLE(OILPAN)
ASSERT(m_normalRefCount > 0);
- atomicDecrement(&m_connectionRefCount);
- if (m_connectionRefCount == 0 && m_normalRefCount > 1)
- disableOutputsIfNecessary();
#endif
+ if (!m_connectionRefCount)
+ disableOutputsIfNecessary();
}
#if !ENABLE(OILPAN)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698