Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: Source/core/inspector/InspectorConsoleMessage.cpp

Issue 466753002: DevTools: Do not push to frontend messages from worker while it is alive (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove unneeded changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorConsoleMessage.cpp
diff --git a/Source/core/inspector/InspectorConsoleMessage.cpp b/Source/core/inspector/InspectorConsoleMessage.cpp
index fc496de080d664fe8fc15c49bdb514dcebfa83a7..d8cb440573d9afdb62055cf664e0cd442e517ce5 100644
--- a/Source/core/inspector/InspectorConsoleMessage.cpp
+++ b/Source/core/inspector/InspectorConsoleMessage.cpp
@@ -56,6 +56,7 @@ InspectorConsoleMessage::InspectorConsoleMessage(bool canGenerateCallStack, Mess
, m_column(0)
, m_requestId(IdentifiersFactory::requestId(0))
, m_timestamp(WTF::currentTime())
+ , m_workerProxy(nullptr)
{
autogenerateMetadata(canGenerateCallStack);
}
@@ -71,6 +72,7 @@ InspectorConsoleMessage::InspectorConsoleMessage(bool canGenerateCallStack, Mess
, m_column(column)
, m_requestId(IdentifiersFactory::requestId(requestIdentifier))
, m_timestamp(WTF::currentTime())
+ , m_workerProxy(nullptr)
{
autogenerateMetadata(canGenerateCallStack, scriptState);
}
@@ -86,6 +88,7 @@ InspectorConsoleMessage::InspectorConsoleMessage(MessageSource source, MessageTy
, m_column(0)
, m_requestId(IdentifiersFactory::requestId(requestIdentifier))
, m_timestamp(WTF::currentTime())
+ , m_workerProxy(nullptr)
{
if (callStack && callStack->size()) {
const ScriptCallFrame& frame = callStack->at(0);
@@ -108,6 +111,7 @@ InspectorConsoleMessage::InspectorConsoleMessage(bool canGenerateCallStack, Mess
, m_column(0)
, m_requestId(IdentifiersFactory::requestId(requestIdentifier))
, m_timestamp(WTF::currentTime())
+ , m_workerProxy(nullptr)
{
autogenerateMetadata(canGenerateCallStack, scriptState);
}
@@ -188,6 +192,9 @@ static TypeBuilder::Console::ConsoleMessage::Level::Enum messageLevelValue(Messa
void InspectorConsoleMessage::addToFrontend(InspectorFrontend::Console* frontend, InjectedScriptManager* injectedScriptManager, bool generatePreview)
{
+ if (m_workerProxy)
+ return;
+
RefPtr<TypeBuilder::Console::ConsoleMessage> jsonObj = TypeBuilder::Console::ConsoleMessage::create()
.setSource(messageSourceValue(m_source))
.setLevel(messageLevelValue(m_level))

Powered by Google App Engine
This is Rietveld 408576698