Source/core/inspector/InspectorInstrumentation.idl - Issue 466753002: DevTools: Do not push to frontend messages from worker while it is alive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorInstrumentation.idl

Issue 466753002: DevTools: Do not push to frontend messages from worker while it is alive (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove unneeded changes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/inspector/InspectorConsoleMessage.cpp ('k') | Source/core/workers/WorkerMessagingProxy.h » ('j') | Source/core/workers/WorkerMessagingProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorInstrumentation.idl

diff --git a/Source/core/inspector/InspectorInstrumentation.idl b/Source/core/inspector/InspectorInstrumentation.idl

index 85066c88951b8a7ea5282e592e5ddf4198729531..c9e3cd0c06a48d1f178c648bc8635a600cba4ded 100644

--- a/Source/core/inspector/InspectorInstrumentation.idl

+++ b/Source/core/inspector/InspectorInstrumentation.idl

@@ -397,7 +397,7 @@ interface InspectorInstrumentation {

[WorkerRuntime]

void willEvaluateWorkerScript([Keep] WorkerGlobalScope* context, int workerThreadStartMode);

- [Worker]

+ [Worker, Console]

vsevik 2014/08/12 14:25:13 Let's make an explicit call on the call site inste

sergeyv 2014/08/12 15:37:53 Done.

void workerGlobalScopeTerminated(ExecutionContext*, WorkerGlobalScopeProxy* proxy);

[Profiler, Timeline]

@@ -484,6 +484,9 @@ class ConsoleMessage;

[Console]

void addMessageToConsole(ExecutionContext* context, ConsoleMessage* consoleMessage);

+ [Console]

+ void addMessageToConsoleFromWorker(ExecutionContext* context, WorkerGlobalScopeProxy* proxy, ConsoleMessage* consoleMessage);

[Console, Debugger]

void addConsoleAPIMessageToConsole(ExecutionContext* context, MessageType type, MessageLevel level, const String& message, ScriptState* state, PassRefPtrWillBeRawPtr<ScriptArguments> arguments, unsigned long requestIdentifier = 0);