Subzero: Factor our commonalities between mov-like instructions.

Subzero: Factor our commonalities between mov-like instructions.

Introduce a base class for mov, movq, and movp instruction classes.

BUG=none
R=jvoung@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e58178a

[jvoung (off chromium), 2014-08-12 19:49:47]

https://codereview.chromium.org/466733005/diff/1/src/IceInstX8632.h
File src/IceInstX8632.h (right):

https://codereview.chromium.org/466733005/diff/1/src/IceInstX8632.h#newcode582
src/IceInstX8632.h:582: virtual bool isRedundantAssign() const {
It might be good to leave this in the .cpp file instead of having it "inline",
since it's not a completely trivial function.

[wala, 2014-08-12 20:06:57]

https://codereview.chromium.org/466733005/diff/1/src/IceInstX8632.h
File src/IceInstX8632.h (right):

https://codereview.chromium.org/466733005/diff/1/src/IceInstX8632.h#newcode582
src/IceInstX8632.h:582: virtual bool isRedundantAssign() const {
On 2014/08/12 19:49:47, jvoung wrote:
> It might be good to leave this in the .cpp file instead of having it "inline",
> since it's not a completely trivial function.

Done.

[jvoung (off chromium), 2014-08-12 20:11:55]

lgtm

[wala, 2014-08-12 20:15:19]

Committed patchset #2 manually as e58178a (presubmit successful).