Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: ui/app_list/views/apps_grid_view_delegate.h

Issue 466693002: Fix app list DCHECKs getting hit when model updates occur during dragging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add test comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/views/apps_grid_view.cc ('k') | ui/app_list/views/apps_grid_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/apps_grid_view_delegate.h
diff --git a/ui/app_list/views/apps_grid_view_delegate.h b/ui/app_list/views/apps_grid_view_delegate.h
index 14b31a063c8cdcb7c3242bec6fdeffd304adde19..3be3eeeef5882409dc7e7d034df9b73d9736c99b 100644
--- a/ui/app_list/views/apps_grid_view_delegate.h
+++ b/ui/app_list/views/apps_grid_view_delegate.h
@@ -30,6 +30,11 @@ class APP_LIST_EXPORT AppsGridViewDelegate {
const std::string& app_id,
const base::Callback<void(const base::FilePath&)>& callback) = 0;
+ // Called by the root grid view to cancel a drag that started inside a folder.
+ // This can occur when the root grid is visible for a reparent and its model
+ // changes, necessitating a cancel of the drag operation.
+ virtual void CancelDragInActiveFolder() = 0;
+
protected:
virtual ~AppsGridViewDelegate() {}
};
« no previous file with comments | « ui/app_list/views/apps_grid_view.cc ('k') | ui/app_list/views/apps_grid_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698