Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: ui/app_list/views/apps_grid_view_delegate.h

Issue 466693002: Fix app list DCHECKs getting hit when model updates occur during dragging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add test comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/app_list/views/apps_grid_view.cc ('k') | ui/app_list/views/apps_grid_view_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_APP_LIST_VIEWS_APPS_GRID_VIEW_DELEGATE_H_ 5 #ifndef UI_APP_LIST_VIEWS_APPS_GRID_VIEW_DELEGATE_H_
6 #define UI_APP_LIST_VIEWS_APPS_GRID_VIEW_DELEGATE_H_ 6 #define UI_APP_LIST_VIEWS_APPS_GRID_VIEW_DELEGATE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback_forward.h" 10 #include "base/callback_forward.h"
(...skipping 12 matching lines...) Expand all
23 // Invoked when an item is activated on the grid view. |event_flags| contains 23 // Invoked when an item is activated on the grid view. |event_flags| contains
24 // the flags of the keyboard/mouse event that triggers the activation request. 24 // the flags of the keyboard/mouse event that triggers the activation request.
25 virtual void ActivateApp(AppListItem* item, int event_flags) = 0; 25 virtual void ActivateApp(AppListItem* item, int event_flags) = 0;
26 26
27 // Gets the path to a shortcut for the app represented by |item|. |callback| 27 // Gets the path to a shortcut for the app represented by |item|. |callback|
28 // may be run immediately. 28 // may be run immediately.
29 virtual void GetShortcutPathForApp( 29 virtual void GetShortcutPathForApp(
30 const std::string& app_id, 30 const std::string& app_id,
31 const base::Callback<void(const base::FilePath&)>& callback) = 0; 31 const base::Callback<void(const base::FilePath&)>& callback) = 0;
32 32
33 // Called by the root grid view to cancel a drag that started inside a folder.
34 // This can occur when the root grid is visible for a reparent and its model
35 // changes, necessitating a cancel of the drag operation.
36 virtual void CancelDragInActiveFolder() = 0;
37
33 protected: 38 protected:
34 virtual ~AppsGridViewDelegate() {} 39 virtual ~AppsGridViewDelegate() {}
35 }; 40 };
36 41
37 } // namespace app_list 42 } // namespace app_list
38 43
39 #endif // UI_APP_LIST_VIEWS_APPS_GRID_VIEW_DELEGATE_H_ 44 #endif // UI_APP_LIST_VIEWS_APPS_GRID_VIEW_DELEGATE_H_
OLDNEW
« no previous file with comments | « ui/app_list/views/apps_grid_view.cc ('k') | ui/app_list/views/apps_grid_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698