Issue 466673004: Use CommonNodeCache for heap constants in ChangeLowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 466673004: Use CommonNodeCache for heap constants in ChangeLowering. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Use CommonNodeCache for heap constants in ChangeLowering. TEST=compiler-unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23077

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+309 lines, -207 lines)			Patch
M	src/compiler/change-lowering.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/compiler/common-node-cache.h	View		3 chunks	+14 lines, -6 lines	0 comments	Download
M	src/compiler/node-cache.h	View	1	2 chunks	+18 lines, -10 lines	0 comments	Download
M	src/compiler/node-cache.cc	View	1	4 chunks	+12 lines, -24 lines	0 comments	Download
M	test/cctest/cctest.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	test/cctest/compiler/test-node-cache.cc	View		1 chunk	+0 lines, -160 lines	0 comments	Download
A	test/compiler-unittests/common-node-cache-unittest.cc	View		1 chunk	+125 lines, -0 lines	0 comments	Download
M	test/compiler-unittests/compiler-unittests.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	test/compiler-unittests/node-cache-unittest.cc	View		1 chunk	+129 lines, -0 lines	0 comments	Download
M	testing/gtest-type-names.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

6 years, 4 months ago (2014-08-12 12:38:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 23077 (presubmit successful).