Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: src/compiler/common-node-cache.h

Issue 466673004: Use CommonNodeCache for heap constants in ChangeLowering. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Build fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler/change-lowering.cc ('k') | src/compiler/node-cache.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_COMMON_NODE_CACHE_H_ 5 #ifndef V8_COMPILER_COMMON_NODE_CACHE_H_
6 #define V8_COMPILER_COMMON_NODE_CACHE_H_ 6 #define V8_COMPILER_COMMON_NODE_CACHE_H_
7 7
8 #include "src/assembler.h" 8 #include "src/assembler.h"
9 #include "src/compiler/node-cache.h" 9 #include "src/compiler/node-cache.h"
10 #include "src/unique.h"
10 11
11 namespace v8 { 12 namespace v8 {
12 namespace internal { 13 namespace internal {
13 namespace compiler { 14 namespace compiler {
14 15
15 // Bundles various caches for common nodes. 16 // Bundles various caches for common nodes.
16 class CommonNodeCache V8_FINAL : public ZoneObject { 17 class CommonNodeCache V8_FINAL : public ZoneObject {
17 public: 18 public:
18 explicit CommonNodeCache(Zone* zone) : zone_(zone) {} 19 explicit CommonNodeCache(Zone* zone) : zone_(zone) {}
19 20
20 Node** FindInt32Constant(int32_t value) { 21 Node** FindInt32Constant(int32_t value) {
21 return int32_constants_.Find(zone_, value); 22 return int32_constants_.Find(zone_, value);
22 } 23 }
23 24
24 Node** FindFloat64Constant(double value) { 25 Node** FindFloat64Constant(double value) {
25 // We canonicalize double constants at the bit representation level. 26 // We canonicalize double constants at the bit representation level.
26 return float64_constants_.Find(zone_, BitCast<int64_t>(value)); 27 return float64_constants_.Find(zone_, BitCast<int64_t>(value));
27 } 28 }
28 29
29 Node** FindExternalConstant(ExternalReference reference) { 30 Node** FindExternalConstant(ExternalReference reference) {
30 return external_constants_.Find(zone_, reference.address()); 31 return external_constants_.Find(
32 zone_, reinterpret_cast<intptr_t>(reference.address()));
31 } 33 }
32 34
33 Node** FindNumberConstant(double value) { 35 Node** FindNumberConstant(double value) {
34 // We canonicalize double constants at the bit representation level. 36 // We canonicalize double constants at the bit representation level.
35 return number_constants_.Find(zone_, BitCast<int64_t>(value)); 37 return number_constants_.Find(zone_, BitCast<int64_t>(value));
36 } 38 }
37 39
38 Zone* zone() const { return zone_; } 40 Node** FindHeapConstant(PrintableUnique<HeapObject> object) {
41 return heap_constants_.Find(zone_, object.Hashcode());
42 }
39 43
40 private: 44 private:
41 Int32NodeCache int32_constants_; 45 Int32NodeCache int32_constants_;
42 Int64NodeCache float64_constants_; 46 Int64NodeCache float64_constants_;
43 PtrNodeCache external_constants_; 47 IntPtrNodeCache external_constants_;
44 Int64NodeCache number_constants_; 48 Int64NodeCache number_constants_;
49 IntPtrNodeCache heap_constants_;
45 Zone* zone_; 50 Zone* zone_;
51
52 DISALLOW_COPY_AND_ASSIGN(CommonNodeCache);
46 }; 53 };
47 } 54
48 } 55 } // namespace compiler
49 } // namespace v8::internal::compiler 56 } // namespace internal
57 } // namespace v8
50 58
51 #endif // V8_COMPILER_COMMON_NODE_CACHE_H_ 59 #endif // V8_COMPILER_COMMON_NODE_CACHE_H_
OLDNEW
« no previous file with comments | « src/compiler/change-lowering.cc ('k') | src/compiler/node-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698