Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 466653002: Revert of Added multi-finger gestures to touch_exploration_controller (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, lisayin
Base URL:
https://chromium.googlesource.com/chromium/src.git@passthrough
Project:
chromium
Visibility:
Public.

Description

Revert of Added multi-finger gestures to touch_exploration_controller (https://codereview.chromium.org/429633002/) Reason for revert: tree-closer ui_unittests failing on Linux Chromium OS ASan LSan Tests (3) test TouchExplorationTest.AllFingerPermutations failing since http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2708 I don't think the failing test itself is generating output, but there are some LOG(INFO)s that have been snuck through with the VLOG(0) trick which might help diagnose. Original issue's description: > Added multi-finger gestures to touch_exploration_controller > > Two fingers: up is go to top, down is read from here, left is browser back, right is browser forward. > Three fingers: up and down map to page up/down. > Four fingers: up is home page, down is refresh. > > Three/four finger left/right mappings to be added to the CL soon! > > NOTRY=true (failing android dbg tests - this is not related to Android) > BUG=387304 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288857 TBR=dmazzoni@chromium.org,aboxhall@chromium.org,mfomitchev@chromium.org,lisayin@chromium.org,evy@chromium.org NOTREECHECKS=true NOTRY=true BUG=387304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -417 lines) Patch
M ui/chromeos/touch_exploration_controller.h View 10 chunks +24 lines, -39 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.cc View 32 chunks +200 lines, -269 lines 0 comments Download
M ui/chromeos/touch_exploration_controller_unittest.cc View 11 chunks +71 lines, -109 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of Added multi-finger gestures to touch_exploration_controller
6 years, 4 months ago (2014-08-12 04:22:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/466653002/1
6 years, 4 months ago (2014-08-12 04:24:56 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 04:27:04 UTC) #3
Message was sent while issue was closed.
Change committed as 288914

Powered by Google App Engine
This is Rietveld 408576698