Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 466503002: SkTileGrid: store insertion order, return results sorted by that. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkTileGrid: store insertion order, return results sorted by that. This removes the need to assume the void* are SkPictureStateTree::Data*. BUG=skia: Committed: https://skia.googlesource.com/skia/+/03bde3e6fa8deaf635bd19b45de69ebea71ec299

Patch Set 1 #

Patch Set 2 : Focus dilation check. #

Patch Set 3 : More const. #

Total comments: 2

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -99 lines) Patch
M dm/DMCpuGMTask.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkTileGrid.h View 1 2 3 3 chunks +14 lines, -20 lines 0 comments Download
M src/core/SkTileGrid.cpp View 1 2 4 chunks +63 lines, -77 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mtklein
6 years, 4 months ago (2014-08-11 21:21:45 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-11 21:21:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/466503002/40001
6 years, 4 months ago (2014-08-11 21:22:38 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-11 21:22:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 03:22:44 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 4 months ago (2014-08-12 03:22:45 UTC) #6
robertphillips
lgtm + 2 comment suggestions https://codereview.chromium.org/466503002/diff/40001/src/core/SkTileGrid.h File src/core/SkTileGrid.h (right): https://codereview.chromium.org/466503002/diff/40001/src/core/SkTileGrid.h#newcode53 src/core/SkTileGrid.h:53: struct Entry { // ...
6 years, 4 months ago (2014-08-12 12:44:38 UTC) #7
mtklein
On 2014/08/12 12:44:38, robertphillips wrote: > lgtm + 2 comment suggestions > > https://codereview.chromium.org/466503002/diff/40001/src/core/SkTileGrid.h > ...
6 years, 4 months ago (2014-08-12 13:52:38 UTC) #8
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-12 13:53:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/466503002/60001
6 years, 4 months ago (2014-08-12 13:53:17 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 14:01:31 UTC) #11
Message was sent while issue was closed.
Change committed as 03bde3e6fa8deaf635bd19b45de69ebea71ec299

Powered by Google App Engine
This is Rietveld 408576698