Fix chrome/BUILD.gn.

Fix chrome/BUILD.gn.

Building target "chrome:resources" once works, rebuilding it again
fails with this error:

ninja:error: expected depfile 'gen/chrome/resources_grit.d' to mention
'gen/chrome/grit/common_resources.h', got 'gen/chrome/grit/renderer_resources.h'

Making sure the resources targets have unique names fixes this problem.

BUG=None
R=phajdan.jr@chromium.org, zerny@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289283

[Joao da Silva, 2014-08-13 13:23:47]

https://codereview.chromium.org/466403002/diff/1/chrome/BUILD.gn
File chrome/BUILD.gn (left):

https://codereview.chromium.org/466403002/diff/1/chrome/BUILD.gn#oldcode15
chrome/BUILD.gn:15: "//chrome/renderer:resources",
I think these 3 duplicated names are the problem but am not sure. Anyway, the
build issue is gone after the rename. WDYT?

[Paweł Hajdan Jr., 2014-08-13 13:27:39]

LGTM to green the tree, +Brett, Dirk FYI for expert GN recommendations

[Joao da Silva, 2014-08-13 13:28:43]

Seems like the issue comes from

https://codereview.chromium.org/468733003

Because those 3 "resource" targets are outputing to the same directory after
zerny's fix:

  output_dir = "$root_gen_dir/chrome"

So is this CL the right fix, or should the output_dirs be different?

[zerny-chromium, 2014-08-13 13:30:44]

On 2014/08/13 13:28:43, Joao da Silva wrote:
> Seems like the issue comes from
> 
> https://codereview.chromium.org/468733003
> 
> Because those 3 "resource" targets are outputing to the same directory after
> zerny's fix:
> 
>   output_dir = "$root_gen_dir/chrome"
> 
> So is this CL the right fix, or should the output_dirs be different?

Locally I still am getting the error on a rebuild (just not for target
chrome:resources).
Still trying to get a reproducible description.

[zerny-chromium, 2014-08-13 14:01:11]

On 2014/08/13 13:30:44, zerny-chromium wrote:
> On 2014/08/13 13:28:43, Joao da Silva wrote:
> > Seems like the issue comes from
> > 
> > https://codereview.chromium.org/468733003
> > 
> > Because those 3 "resource" targets are outputing to the same directory after
> > zerny's fix:
> > 
> >   output_dir = "$root_gen_dir/chrome"
> > 
> > So is this CL the right fix, or should the output_dirs be different?
> 
> Locally I still am getting the error on a rebuild (just not for target
> chrome:resources).
> Still trying to get a reproducible description.

I'm doing a clobber build locally, but lets get this in in the meantime. LGTM

[Joao da Silva, 2014-08-13 14:01:38]

I'm going to land this to get the tree going again.

Brett, Dirk: PTAL later. https://codereview.chromium.org/468733003 makes these
and other targets have the same output_dir, and it's not clear if the right fix
is to change the output_dirs or rename the targets.

[Joao da Silva, 2014-08-13 14:03:04]

Committed patchset #2 manually as 289283.

[Dirk Pranke, 2014-08-13 19:49:35]

On 2014/08/13 13:28:43, Joao da Silva wrote:
> Seems like the issue comes from
> 
> https://codereview.chromium.org/468733003
> 
> Because those 3 "resource" targets are outputing to the same directory after
> zerny's fix:
> 
>   output_dir = "$root_gen_dir/chrome"
> 
> So is this CL the right fix, or should the output_dirs be different?

It's fine to have landed this to fix things up, but some combination of this fix
and the one in 468733003 seem wrong to me. 

It's not obvious to me that the prior one was the right thing to do (i.e., that
we should match GYP's behavior), but Brett's definitely closer to the grit
things than I am.

Brett, WDYT?

[brettw, 2014-08-13 20:21:34]

I think it's bad to manually specify the chrome directory for all of these, but
we do need to match GYP. I think the correct solution would be to allow one to
specify an output_name for a grit target to resolve collisions.

[brettw, 2014-08-13 20:33:23]

I did: https://codereview.chromium.org/469893002/