Issue 468733003: GN: Fix build after r289163 / r289149.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 468733003: GN: Fix build after r289163 / r289149. (Closed)

Created:
6 years, 4 months ago by zerny-chromium

Modified:
6 years, 4 months ago

Reviewers:
Lei Zhang, brettw

CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, jochen+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

GN: Fix build after r289163 / r289149. This reapplies r289149: GN: Specify grit generated output paths to be the same as gyp's. together with outstanding CL: https://codereview.chromium.org/467023003/ TBR=brettw@chromium.org,thestig@chromium.org NOTRY=true NOTREECHECKS=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289264

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -7 lines)			Patch
M	chrome/app/BUILD.gn	View	4 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/app/resources/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/BUILD.gn	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/shell/BUILD.gn	View	2 chunks	+1 line, -1 line	0 comments	Download
M	extensions/BUILD.gn	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	webkit/glue/resources/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/468733003/1

6 years, 4 months ago (2014-08-13 11:21:43 UTC) #3

Message was sent while issue was closed.

Change committed as 289264