Issue 4664006: laptop-mode-tools: replace iwconfig & co with iw

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4664006: laptop-mode-tools: replace iwconfig & co with iw (Closed)

Created:
10 years, 1 month ago by Sam Leffler

Modified:
9 years, 7 months ago

Reviewers:
Sameer Nanda, Simon Que

CC:
chromium-os-reviews_chromium.org, msb+crosoverlay_chromium.org, adlr, anush

Base URL:
ssh://git@gitrw.chromium.org:9222/chromiumos-overlay.git@master

Visibility:
Public.

Description

laptop-mode-tools: replace iwconfig & co with iw Drop iwconfig & co and bring in iw for changes that use iw to manager power save on wireless devices. BUG=7138 TEST=gmerge to device and verify iwconfig is missing and iw is present Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a1ef437

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	app-laptop/laptop-mode-tools/laptop-mode-tools-9999.ebuild	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sameer Nanda

LGTM with nit. http://codereview.chromium.org/4664006/diff/1/app-laptop/laptop-mode-tools/laptop-mode-tools-9999.ebuild File app-laptop/laptop-mode-tools/laptop-mode-tools-9999.ebuild (right): http://codereview.chromium.org/4664006/diff/1/app-laptop/laptop-mode-tools/laptop-mode-tools-9999.ebuild#newcode30 app-laptop/laptop-mode-tools/laptop-mode-tools-9999.ebuild:30: net-wireless/iw spaces instead of tabs.

10 years, 1 month ago (2010-11-10 17:52:40 UTC) #3

Sam Leffler

10 years, 1 month ago (2010-11-10 18:12:10 UTC) #4

http://codereview.chromium.org/4664006/diff/1/app-laptop/laptop-mode-tools/la...
File app-laptop/laptop-mode-tools/laptop-mode-tools-9999.ebuild (right):

http://codereview.chromium.org/4664006/diff/1/app-laptop/laptop-mode-tools/la...
app-laptop/laptop-mode-tools/laptop-mode-tools-9999.ebuild:30: net-wireless/iw
The whole file uses tabs and not spaces; gonna push as-is.

Expand Messages | Collapse Messages