Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2400)

Unified Diff: printing/printing_context_gtk.cc

Issue 46623002: Move settings setup for PDF and cloud print into single location in PrintingContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/printing_context_gtk.cc
diff --git a/printing/printing_context_gtk.cc b/printing/printing_context_gtk.cc
index 6cf0015434783a61cb3b7e2732a5fc5f7a97e262..d757df726fdb0cd581e26bcd0668b65d60389612 100644
--- a/printing/printing_context_gtk.cc
+++ b/printing/printing_context_gtk.cc
@@ -78,8 +78,21 @@ PrintingContext::Result PrintingContextGtk::UseDefaultSettings() {
return OK;
}
+gfx::Size PrintingContextGtk::GetPdfPaperSizeDeviceUnits() {
+ GtkPageSetup* page_setup = gtk_page_setup_new();
+
+ gfx::SizeF paper_size(
+ gtk_page_setup_get_paper_width(page_setup, GTK_UNIT_INCH),
+ gtk_page_setup_get_paper_height(page_setup, GTK_UNIT_INCH));
+
+ g_object_unref(page_setup);
+
+ return gfx::Size(
+ paper_size.width() * settings_.device_units_per_inch(),
+ paper_size.height() * settings_.device_units_per_inch());
+}
+
PrintingContext::Result PrintingContextGtk::UpdatePrinterSettings(
- bool target_is_pdf,
bool external_preview) {
DCHECK(!in_print_job_);
DCHECK(!external_preview) << "Not implemented";
@@ -89,7 +102,7 @@ PrintingContext::Result PrintingContextGtk::UpdatePrinterSettings(
print_dialog_->AddRefToDialog();
}
- if (!print_dialog_->UpdateSettings(target_is_pdf, &settings_))
+ if (!print_dialog_->UpdateSettings(&settings_))
return OnError();
return OK;

Powered by Google App Engine
This is Rietveld 408576698