Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: printing/print_settings_initializer_mac.cc

Issue 46623002: Move settings setup for PDF and cloud print into single location in PrintingContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/print_settings_initializer_mac.cc
diff --git a/printing/print_settings_initializer_mac.cc b/printing/print_settings_initializer_mac.cc
index 9333ec9e8b8dd2591566eb319369eaa3e9f63268..7dc41a657030d4daef131009aa400d272ade2d6e 100644
--- a/printing/print_settings_initializer_mac.cc
+++ b/printing/print_settings_initializer_mac.cc
@@ -6,6 +6,7 @@
#include "base/strings/sys_string_conversions.h"
#include "printing/print_settings.h"
+#include "printing/units.h"
namespace printing {
@@ -54,9 +55,10 @@ void PrintSettingsInitializerMac::InitPrintSettings(
(page_rect.right - page_rect.left),
(page_rect.bottom - page_rect.top));
+ DCHECK_EQ(print_settings->device_units_per_inch(), kPointsPerInch);
Lei Zhang 2013/11/01 18:27:13 nit: reverse the two arguments. DCHECK_EQ(expected
Vitaly Buka (NO REVIEWS) 2013/11/01 19:35:09 This looks like contradicts to example in logging.
print_settings->SetPrinterPrintableArea(physical_size_device_units,
printable_area_device_units,
- 72, false);
+ false);
}
} // namespace printing

Powered by Google App Engine
This is Rietveld 408576698