Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: printing/printing_context.h

Issue 46623002: Move settings setup for PDF and cloud print into single location in PrintingContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/printing_context.h
diff --git a/printing/printing_context.h b/printing/printing_context.h
index 7fa90d261a6dae8e00b9161504feebd264e81fdc..7a0a8c8b99ad9d1839ca5322ac15b4ded9be9cc8 100644
--- a/printing/printing_context.h
+++ b/printing/printing_context.h
@@ -51,14 +51,13 @@ class PRINTING_EXPORT PrintingContext {
// default device settings.
virtual Result UseDefaultSettings() = 0;
+ // Returns paper size to be used for PDF or Cloud Print in device units.
+ virtual gfx::Size GetPdfPaperSizeDeviceUnits() = 0;
+
// Updates printer settings.
- // |target_is_pdf| is true if implementation needs to generate PDF without
- // actual printing. In this case implementation may avoid setup of native
- // print system. Ex. "save to pdf" or Cloud Print.
// |external_preview| is true if pdf is going to be opened in external
// preview. Used by MacOS only now to open Preview.app.
- virtual Result UpdatePrinterSettings(bool target_is_pdf,
- bool external_preview) = 0;
+ virtual Result UpdatePrinterSettings(bool external_preview) = 0;
// Updates Print Settings. |job_settings| contains all print job
// settings information. |ranges| has the new page range settings.

Powered by Google App Engine
This is Rietveld 408576698