Revert of Battery Status API: implementation for Windows.

Revert of Battery Status API: implementation for Windows. (patchset #5 of https://codereview.chromium.org/447853002/)

Reason for revert:
Breaks execution on XP. See these telemetry tests, which may be the only thing that actually launch the browser itself on XP:

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34947

I manually built and ran on an XP VM and received a message that UnregisterPowerSettingNotification could not be located in user32.dll

Original issue's description:
> Battery Status API: implementation for Windows.
> 
> Implementation of the Battery Status API for the Windows platform.
> Implementation uses a message window to receive battery notifications.
> On versions prior to Vista there is limited support as the
> RegisterPowerSettingNotification function is not available.
> 
> BUG=122593
> TEST=http://jsbin.com/battery-status-test (manual)
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289634

TBR=mvanouwerkerk@chromium.org,mlamouri@chromium.org,scottmg@chromium.org,cpu@chromium.org,timvolodine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=122593

[erikwright (departed), 2014-08-15 19:21:14]

Created Revert of Battery Status API: implementation for Windows.

[commit-bot: I haz the power, 2014-08-15 19:22:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikwright@chromium.org/466223006/1

[erikwright (departed), 2014-08-15 19:24:30]

The CQ bit was unchecked by erikwright@chromium.org

[scottmg, 2014-08-15 19:25:30]

Wait, there was already a fix landed.


On Fri, Aug 15, 2014 at 12:21 PM, <erikwright@chromium.org> wrote:

> Reviewers: Michael van Ouwerkerk, Mounir Lamouri, scottmg, cpu (slow to
> respond), timvolodine,
>
> Message:
> Created Revert of Battery Status API: implementation for Windows.
>
> Description:
> Revert of Battery Status API: implementation for Windows. (patchset #5 of
> https://codereview.chromium.org/447853002/)
>
> Reason for revert:
> Breaks execution on XP. See these telemetry tests, which may be the only
> thing
> that actually launch the browser itself on XP:
>
> http://build.chromium.org/p/chromium.win/builders/XP%
> 20Tests%20%282%29/builds/34947
>
> I manually built and ran on an XP VM and received a message that
> UnregisterPowerSettingNotification could not be located in user32.dll
>
> Original issue's description:
>
>> Battery Status API: implementation for Windows.
>>
>
>  Implementation of the Battery Status API for the Windows platform.
>> Implementation uses a message window to receive battery notifications.
>> On versions prior to Vista there is limited support as the
>> RegisterPowerSettingNotification function is not available.
>>
>
>  BUG=122593
>> TEST=http://jsbin.com/battery-status-test (manual)
>>
>
>  Committed: https://src.chromium.org/viewvc/chrome?view=rev&
>> revision=289634
>>
>
> TBR=mvanouwerkerk@chromium.org,mlamouri@chromium.org,scottmg@chromium.org,
> cpu@chromium.org,timvolodine@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=122593
>
> Please review this at https://codereview.chromium.org/466223006/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+0, -316 lines):
>   D content/browser/battery_status/battery_status_manager_win.h
>   D content/browser/battery_status/battery_status_manager_win.cc
>   D content/browser/battery_status/battery_status_manager_win_unittest.cc
>   M content/content_browser.gypi
>   M content/content_tests.gypi
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2014-08-15 19:26:52]

Should be OK after
http://src.chromium.org/viewvc/chrome?revision=289956&view=revision ?


On Fri, Aug 15, 2014 at 12:25 PM, Scott Graham <scottmg@chromium.org> wrote:

> Wait, there was already a fix landed.
>
>
> On Fri, Aug 15, 2014 at 12:21 PM, <erikwright@chromium.org> wrote:
>
>> Reviewers: Michael van Ouwerkerk, Mounir Lamouri, scottmg, cpu (slow to
>> respond), timvolodine,
>>
>> Message:
>> Created Revert of Battery Status API: implementation for Windows.
>>
>> Description:
>> Revert of Battery Status API: implementation for Windows. (patchset #5 of
>> https://codereview.chromium.org/447853002/)
>>
>> Reason for revert:
>> Breaks execution on XP. See these telemetry tests, which may be the only
>> thing
>> that actually launch the browser itself on XP:
>>
>> http://build.chromium.org/p/chromium.win/builders/XP%
>> 20Tests%20%282%29/builds/34947
>>
>> I manually built and ran on an XP VM and received a message that
>> UnregisterPowerSettingNotification could not be located in user32.dll
>>
>> Original issue's description:
>>
>>> Battery Status API: implementation for Windows.
>>>
>>
>>  Implementation of the Battery Status API for the Windows platform.
>>> Implementation uses a message window to receive battery notifications.
>>> On versions prior to Vista there is limited support as the
>>> RegisterPowerSettingNotification function is not available.
>>>
>>
>>  BUG=122593
>>> TEST=http://jsbin.com/battery-status-test (manual)
>>>
>>
>>  Committed: https://src.chromium.org/viewvc/chrome?view=rev&
>>> revision=289634
>>>
>>
>> TBR=mvanouwerkerk@chromium.org,mlamouri@chromium.org,scottmg@chromium.org
>> ,cpu@chromium.org,timvolodine@chromium.org
>> NOTREECHECKS=true
>> NOTRY=true
>> BUG=122593
>>
>> Please review this at https://codereview.chromium.org/466223006/
>>
>> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>>
>> Affected files (+0, -316 lines):
>>   D content/browser/battery_status/battery_status_manager_win.h
>>   D content/browser/battery_status/battery_status_manager_win.cc
>>   D content/browser/battery_status/battery_status_manager_win_unittest.cc
>>   M content/content_browser.gypi
>>   M content/content_tests.gypi
>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[erikwright (departed), 2014-08-15 19:27:41]

Thanks.


On Fri, Aug 15, 2014 at 3:26 PM, Scott Graham <scottmg@chromium.org> wrote:

> Should be OK after
> http://src.chromium.org/viewvc/chrome?revision=289956&view=revision ?
>
>
> On Fri, Aug 15, 2014 at 12:25 PM, Scott Graham <scottmg@chromium.org>
> wrote:
>
>> Wait, there was already a fix landed.
>>
>>
>> On Fri, Aug 15, 2014 at 12:21 PM, <erikwright@chromium.org> wrote:
>>
>>> Reviewers: Michael van Ouwerkerk, Mounir Lamouri, scottmg, cpu (slow to
>>> respond), timvolodine,
>>>
>>> Message:
>>> Created Revert of Battery Status API: implementation for Windows.
>>>
>>> Description:
>>> Revert of Battery Status API: implementation for Windows. (patchset #5 of
>>> https://codereview.chromium.org/447853002/)
>>>
>>> Reason for revert:
>>> Breaks execution on XP. See these telemetry tests, which may be the only
>>> thing
>>> that actually launch the browser itself on XP:
>>>
>>> http://build.chromium.org/p/chromium.win/builders/XP%
>>> 20Tests%20%282%29/builds/34947
>>>
>>> I manually built and ran on an XP VM and received a message that
>>> UnregisterPowerSettingNotification could not be located in user32.dll
>>>
>>> Original issue's description:
>>>
>>>> Battery Status API: implementation for Windows.
>>>>
>>>
>>>  Implementation of the Battery Status API for the Windows platform.
>>>> Implementation uses a message window to receive battery notifications.
>>>> On versions prior to Vista there is limited support as the
>>>> RegisterPowerSettingNotification function is not available.
>>>>
>>>
>>>  BUG=122593
>>>> TEST=http://jsbin.com/battery-status-test (manual)
>>>>
>>>
>>>  Committed: https://src.chromium.org/viewvc/chrome?view=rev&
>>>> revision=289634
>>>>
>>>
>>> TBR=mvanouwerkerk@chromium.org,mlamouri@chromium.org,scottmg
>>> @chromium.org,cpu@chromium.org,timvolodine@chromium.org
>>> NOTREECHECKS=true
>>> NOTRY=true
>>> BUG=122593
>>>
>>> Please review this at https://codereview.chromium.org/466223006/
>>>
>>> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>>>
>>> Affected files (+0, -316 lines):
>>>   D content/browser/battery_status/battery_status_manager_win.h
>>>   D content/browser/battery_status/battery_status_manager_win.cc
>>>   D content/browser/battery_status/battery_status_manager_
>>> win_unittest.cc
>>>   M content/content_browser.gypi
>>>   M content/content_tests.gypi
>>>
>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.