Issue 466012: Don't ping for extension blacklist when no extensions are installed....

Issue 466012: Don't ping for extension blacklist when no extensions are installed.... (Closed)

Created:
11 years ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't ping for extension blacklist when no extensions are installed. BUG=24168 TEST=covered by unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33720

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -5 lines)			Patch
M	chrome/browser/extensions/extension_browsertests_misc.cc	View	2	4 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_updater.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_updater_unittest.cc	View		4 chunks	+25 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

LGTM. A while back I started a email thread with a few folks on a ...

11 years ago (2009-12-03 02:18:57 UTC) #2

Pam (message me for reviews)

11 years ago (2009-12-03 04:18:12 UTC) #3

Sure. Increasing the timer by a factor of 10 or 100 would be easy too, by
simply ignoring all but 1-in-N pings (even randomly!). I could add that to
this patch trivially.

- Pam

On Wed, Dec 2, 2009 at 6:18 PM, <asargent@chromium.org> wrote:

> LGTM.
>
> A while back I started a email thread with a few folks on a way to solve
> this
> that would still give some of the security benefits of the blacklist but
> keep
> load on the servers minimal. One of the most promising ideas, I think from
> ifette, was when you're installing your first extension, if it isn't from
> the
> gallery, then kick off a request for the blacklist and block installation
> (for a
> few seconds max?) until that came back. In the common case of the request
> finishing quickly, it wouldn't even slow the user down because they'd still
> be
> reading the install dialog, or we could fake things so it seemed like the
> installation was just running a little slow. I'll file a separate bug for
> this
> as an enhancement.
>
>
>
>
> http://codereview.chromium.org/466012
>

Expand Messages | Collapse Messages