Don't ping for extension blacklist when no extensions are installed....

chrome/browser/extensions/extension_updater_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/file_util.h"
 #include "base/rand_util.h"
 #include "base/stl_util-inl.h"
 #include "base/string_util.h"
@@ skipping 43 matching lines @@
 
   virtual Extension* GetExtensionById(const std::string& id, bool) {
     EXPECT_TRUE(false);
     return NULL;
   }
 
   virtual void UpdateExtensionBlacklist(
     const std::vector<std::string>& blacklist) {
     EXPECT_TRUE(false);
   }
+
+  virtual bool HasInstalledExtensions() {
+    EXPECT_TRUE(false);
+    return false;
+  }
  private:
   DISALLOW_COPY_AND_ASSIGN(MockService);
 };
 
 // Class that contains a PrefService and handles cleanup of a temporary file
 // backing it.
 class ScopedTempPrefService {
  public:
   ScopedTempPrefService() {
     // Make sure different tests won't use the same prefs file. It will cause
@@ skipping 35 matching lines @@
     if (update_url)
       input.SetString(extension_manifest_keys::kUpdateURL, *update_url);
     std::string error;
     EXPECT_TRUE(e->InitFromValue(input, false, &error));
     list->push_back(e);
   }
 }
 
 class ServiceForManifestTests : public MockService {
  public:
-  ServiceForManifestTests() {}
+  ServiceForManifestTests() : has_installed_extensions_(false) {}
 
   virtual ~ServiceForManifestTests() {}
 
   virtual Extension* GetExtensionById(const std::string& id, bool) {
     for (ExtensionList::iterator iter = extensions_.begin();
         iter != extensions_.end(); ++iter) {
      if ((*iter)->id() == id) {
        return *iter;
      }
     }
     return NULL;
   }
 
   virtual const ExtensionList* extensions() const { return &extensions_; }
 
   void set_extensions(ExtensionList extensions) {
     extensions_ = extensions;
   }
 
+  virtual bool HasInstalledExtensions() {
+    return has_installed_extensions_;
+  }
+
+  void set_has_installed_extensions(bool value) {
+    has_installed_extensions_ = value;
+  }
+
  private:
   ExtensionList extensions_;
+  bool has_installed_extensions_;
 };
 
 class ServiceForDownloadTests : public MockService {
  public:
   virtual void UpdateExtension(const std::string& id,
                                const FilePath& extension_path) {
     extension_id_ = id;
     install_path_ = extension_path;
   }
 
@@ skipping 158 matching lines @@
     TestURLFetcherFactory factory;
     URLFetcher::set_factory(&factory);
     ScopedTempPrefService prefs;
     scoped_refptr<ExtensionUpdater> updater =
         new ExtensionUpdater(&service, prefs.get(), 60*60*24);
     updater->Start();
 
     // Tell the updater that it's time to do update checks.
     SimulateTimerFired(updater.get());
 
-    // Get the url our mock fetcher was asked to fetch.
+    // No extensions installed, so nothing should have been fetched.
     TestURLFetcher* fetcher =
         factory.GetFetcherByID(ExtensionUpdater::kManifestFetcherId);
+    EXPECT_TRUE(fetcher == NULL);
+
+    // Try again with an extension installed.
+    service.set_has_installed_extensions(true);
+    SimulateTimerFired(updater.get());
+
+    // Get the url our mock fetcher was asked to fetch.
+    fetcher = factory.GetFetcherByID(ExtensionUpdater::kManifestFetcherId);
+    ASSERT_FALSE(fetcher == NULL);
     const GURL& url = fetcher->original_url();
 
     EXPECT_FALSE(url.is_empty());
     EXPECT_TRUE(url.is_valid());
     EXPECT_TRUE(url.SchemeIs("https"));
     EXPECT_EQ("clients2.google.com", url.host());
     EXPECT_EQ("/service/update2/crx", url.path());
 
     // Validate the extension request parameters in the query. It should
     // look something like "?x=id%3D<id>%26v%3D<version>%26uc".
@@ skipping 372 matching lines @@
 // -prodversionmin (shouldn't update if browser version too old)
 // -manifests & updates arriving out of order / interleaved
 // -Profile::GetDefaultRequestContext() returning null
 //  (should not crash, but just do check later)
 // -malformed update url (empty, file://, has query, has a # fragment, etc.)
 // -An extension gets uninstalled while updates are in progress (so it doesn't
 //  "come back from the dead")
 // -An extension gets manually updated to v3 while we're downloading v2 (ie
 //  you don't get downgraded accidentally)
 // -An update manifest mentions multiple updates