Add shoftcut (ctrl-f6) to toggle split view

Add shoftcut (ctrl-f6) to toggle split view

BUG=covered by test.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290633

[mfomitchev, 2014-08-12 18:52:51]

https://codereview.chromium.org/465983002/diff/60001/athena/wm/split_view_con...
File athena/wm/split_view_controller.cc (right):

https://codereview.chromium.org/465983002/diff/60001/athena/wm/split_view_con...
athena/wm/split_view_controller.cc:9: #include
"athena/common/closure_animation_observer.h"
Nice. Not part of this CL, but perhaps ClosureAnimationObserver could live
somewhere in ui/? E.g. there are parts of GestureNav code which might be able to
use it.

https://codereview.chromium.org/465983002/diff/60001/athena/wm/split_view_con...
athena/wm/split_view_controller.cc:49: const gfx::Transform transform;
Can you add a TODO(mfomitchev): Use UpdateLayout()?
I don't think it can handle this transition now, but it should be able to once I
do more work on it.

https://codereview.chromium.org/465983002/diff/60001/athena/wm/split_view_con...
athena/wm/split_view_controller.cc:59: left_window_ =
GetCurrentActivityWindow();
I'd use left_window_ and right_window if they are non-NULL. Ideally I'd also use
UpdateLayout() here instead of setting transform/bounds manually.

Something along these lines:

if (!left_window_) {
  // Init left_window_ and right_window_.
  // We can assume/DCHECK that GetCurrentActivityWindow() is 
  // the last window in window_list_provider_->GetWindowList().
}
DCHECK(right_window);
state_ = ACTIVE;
UpdateLayout(true);

https://codereview.chromium.org/465983002/diff/60001/athena/wm/split_view_con...
athena/wm/split_view_controller.cc:266: ToggleSplitView();
Not doing MoveToFront() can screw up the window order. 

Also, you can imagine ToggleSplitView() doing animations in the future which we
wouldn't want here.

I don't know if there's a good reason to change this now. This code will be
rewritten anyway once we implement overview-splitview.

https://codereview.chromium.org/465983002/diff/60001/athena/wm/split_view_con...
athena/wm/split_view_controller.cc:268: CHECK_EQ(INACTIVE, state_);
This may not hold - you can hit the overview hot key when SplitViewController is
in the SCROLLING state.

[mfomitchev, 2014-08-13 15:08:47]

https://codereview.chromium.org/465983002/diff/60001/athena/wm/split_view_con...
File athena/wm/split_view_controller.cc (right):

https://codereview.chromium.org/465983002/diff/60001/athena/wm/split_view_con...
athena/wm/split_view_controller.cc:59: left_window_ =
GetCurrentActivityWindow();
You can also use ActivateSplitMode() if you land this after
https://codereview.chromium.org/459613008/

[oshima, 2014-08-13 21:04:36]

On 2014/08/13 15:08:47, mfomitchev wrote:
>
https://codereview.chromium.org/465983002/diff/60001/athena/wm/split_view_con...
> File athena/wm/split_view_controller.cc (right):
> 
>
https://codereview.chromium.org/465983002/diff/60001/athena/wm/split_view_con...
> athena/wm/split_view_controller.cc:59: left_window_ =
> GetCurrentActivityWindow();
> You can also use ActivateSplitMode() if you land this after
> https://codereview.chromium.org/459613008/

Will do so.

[oshima, 2014-08-19 15:02:01]

uploaded new patch.

sadrul, can you review this as mfomitchev@ is ooo?

[sadrul, 2014-08-19 16:27:54]

lgtm

https://codereview.chromium.org/465983002/diff/140001/athena/test/athena_test...
File athena/test/athena_test_base.h (right):

https://codereview.chromium.org/465983002/diff/140001/athena/test/athena_test...
athena/test/athena_test_base.h:35: const gfx::Rect& bounds);
+1 Thanks

https://codereview.chromium.org/465983002/diff/140001/athena/wm/window_manage...
File athena/wm/window_manager_impl.cc (right):

https://codereview.chromium.org/465983002/diff/140001/athena/wm/window_manage...
athena/wm/window_manager_impl.cc:264:
split_view_controller_->ActivateSplitMode(left, right);
Doing ActivateSplitMode(NULL, NULL) should also work correctly.

[oshima, 2014-08-19 17:05:33]

https://codereview.chromium.org/465983002/diff/140001/athena/wm/window_manage...
File athena/wm/window_manager_impl.cc (right):

https://codereview.chromium.org/465983002/diff/140001/athena/wm/window_manage...
athena/wm/window_manager_impl.cc:264:
split_view_controller_->ActivateSplitMode(left, right);
On 2014/08/19 16:27:53, sadrul wrote:
> Doing ActivateSplitMode(NULL, NULL) should also work correctly.

good to know. done.

[oshima, 2014-08-19 17:05:46]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-08-19 17:06:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/465983002/160001

[commit-bot: I haz the power, 2014-08-19 17:54:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)

[commit-bot: I haz the power, 2014-08-19 19:41:13]

Committed patchset #3 (160001) as 290633