pkg/analysis_services/test/completion/completion_computer_test.dart - Issue 465843002: respect show/hide combinators when generating suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_services/test/completion/completion_computer_test.dart

Issue 465843002: respect show/hide combinators when generating suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_services/lib/src/completion/local_computer.dart ('k') | pkg/analysis_services/test/completion/completion_test_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_services/test/completion/completion_computer_test.dart

diff --git a/pkg/analysis_services/test/completion/completion_computer_test.dart b/pkg/analysis_services/test/completion/completion_computer_test.dart

index 71678ee92c47ce81f19abd186d3f6dedd1f8fd05..961d00c4d1802f919f89636fc7ad11f25c91e016 100644

--- a/pkg/analysis_services/test/completion/completion_computer_test.dart

+++ b/pkg/analysis_services/test/completion/completion_computer_test.dart

@@ -200,7 +200,7 @@ class MockCompletionComputer extends CompletionComputer {

}

@override

- bool computeFast(CompilationUnit unit,

+ bool computeFast(CompilationUnit unit, AstNode node,

List<CompletionSuggestion> suggestions) {

fastCount++;

if (fastSuggestion != null) {

@@ -210,7 +210,7 @@ class MockCompletionComputer extends CompletionComputer {

}

@override

- Future<bool> computeFull(CompilationUnit unit,

+ Future<bool> computeFull(CompilationUnit unit, AstNode node,

List<CompletionSuggestion> suggestions) {

fullCount++;

if (fullSuggestion != null) {