respect show/hide combinators when generating suggestions

pkg/analysis_services/lib/completion/completion_computer.dart

Index: pkg/analysis_services/lib/completion/completion_computer.dart
diff --git a/pkg/analysis_services/lib/completion/completion_computer.dart b/pkg/analysis_services/lib/completion/completion_computer.dart
index 0962cdfb57fc92073fc9cb729f4573a91f520c12..0903c9e41c6f9ac6e9b45b384ac0a430f7db40c3 100644
--- a/pkg/analysis_services/lib/completion/completion_computer.dart
+++ b/pkg/analysis_services/lib/completion/completion_computer.dart
@@ -23,20 +23,22 @@ abstract class CompletionComputer {
   SearchEngine searchEngine;
 
   /**
-   * Computes the initial set of [CompletionSuggestion]s based on information
-   * already cached in the analysis context. This method should execute
-   * quickly and not block waiting for any analysis.
+   * Given the compilation unit and the node at the completion offset,
+   * this computes the initial set of [CompletionSuggestion]s based on
+   * information already cached in the analysis context.
+   * This method should execute quickly and not block waiting for any analysis.
    * Returns `true` if the computer's work is complete
    * or `false` if [computeFull] should be called to complete the work.
    */
-  bool computeFast(CompilationUnit unit,
+  bool computeFast(CompilationUnit unit, AstNode node,

[scheglov, 2014/08/12 05:02:21]

Would you please document [node]?

[danrubel, 2014/08/12 14:52:56]

It is documented in the comment, but perhaps not clear enough. I reworded it so
that hopefully [node] is more clearly defined.

       List<CompletionSuggestion> suggestions);
 
   /**
-   * Computes [CompletionSuggestion]s for the specified position in the source.
-   * Returns `true` if the receiver modified the list of suggestions.
+   * Given the resolved compilation unit and the node at the completion offset,
+   * this computes [CompletionSuggestion]s for the specified position in the
+   * source. Returns `true` if the receiver modified the list of suggestions.
    */
-  Future<bool> computeFull(CompilationUnit unit,
+  Future<bool> computeFull(CompilationUnit unit, AstNode node,
       List<CompletionSuggestion> suggestions);
 }