Data reduction proxy sessions last no more than 24 hours

Data reduction proxy sessions last no more than 24 hours

This CL ensures that data reduction proxy sessions last no
longer than 24 hours. After 24 hours and on restart, a new
session ID is used.

BUG=402563
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289289

[bengr, 2014-08-12 16:50:46]

marq: everything.

[marq (ping after 24h), 2014-08-12 19:04:40]

LGTM with a legacy naming nit.

https://codereview.chromium.org/465823002/diff/40001/components/data_reductio...
File
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
(right):

https://codereview.chromium.org/465823002/diff/40001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h:63:
void InitAuthenticationOnUI(const std::string& key);
To match other CLs, this should be "OnUIThread".

[bengr, 2014-08-13 01:39:15]

https://codereview.chromium.org/465823002/diff/40001/components/data_reductio...
File
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h
(right):

https://codereview.chromium.org/465823002/diff/40001/components/data_reductio...
components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h:63:
void InitAuthenticationOnUI(const std::string& key);
On 2014/08/12 19:04:39, marq_ wrote:
> To match other CLs, this should be "OnUIThread".

I'm trying to move over to OnUI and OnIO as I like these much better. Note also
that SetKeyOnUI would have to change, which would cascade to a bunch of files.
I've filed crbug.com/403180.

[bengr, 2014-08-13 02:38:39]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-08-13 02:40:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bengr@chromium.org/465823002/40001

[commit-bot: I haz the power, 2014-08-13 04:18:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-13 10:28:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 10:28:46]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[bengr, 2014-08-13 12:49:50]

The CQ bit was checked by bengr@chromium.org

[commit-bot: I haz the power, 2014-08-13 12:51:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bengr@chromium.org/465823002/40001

[commit-bot: I haz the power, 2014-08-13 14:38:47]

Committed patchset #1 (40001) as 289289