Data reduction proxy sessions last no more than 24 hours

components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_AUTH_REQUEST_HANDLER_H_
 #define COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_AUTH_REQUEST_HANDLER_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string16.h"
@@ skipping 42 matching lines @@
                              const net::ProxyServer& proxy_server,
                              net::HttpRequestHeaders* request_headers);
 
   // Sets a new authentication key. This must be called for platforms that do
   // not have a default key defined. See the constructor implementation for
   // those platforms. Must be called on the UI thread.
   void SetKeyOnUI(const std::string& key);
 
  protected:
   void Init();
   void InitAuthenticationOnUI(const std::string& key);

[marq (ping after 24h), 2014/08/12 19:04:39]

To match other CLs, this should be "OnUIThread".

[bengr, 2014/08/13 01:39:15]

I'm trying to move over to OnUI and OnIO as I like these much better. Note also
that SetKeyOnUI would have to change, which would cascade to a bunch of files.
I've filed crbug.com/403180.

 
   void AddAuthorizationHeader(net::HttpRequestHeaders* headers);
 
   // Returns a UTF16 string that's the hash of the configured authentication
   // |key| and |salt|. Returns an empty UTF16 string if no key is configured or
   // the data reduction proxy feature isn't available.
   static base::string16 AuthHashForSalt(int64 salt,
                                         const std::string& key);
   // Visible for testing.
   virtual base::Time Now() const;
   virtual void RandBytes(void* output, size_t length);
 
   // Visible for testing.
   virtual std::string GetDefaultKey() const;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxyAuthRequestHandlerTest,
                            Authorization);
   FRIEND_TEST_ALL_PREFIXES(DataReductionProxyAuthRequestHandlerTest,
                            AuthHashForSalt);
 
-  void InitAuthentication(
-      const std::string& session,
-      const std::string& credentials);
+  // Stores the supplied key and sets up credentials suitable for authenticating
+  // with the data reduction proxy.
+  void InitAuthentication(const std::string& key);
+
+  // Generates a session ID and credentials suitable for authenticating with
+  // the data reduction proxy.
+  void ComputeCredentials(const base::Time& now,
+                          std::string* session,
+                          std::string* credentials);
 
   // Authentication state.
   std::string key_;
 
   // Lives on the IO thread.
   std::string session_;
   std::string credentials_;
 
   // Name of the client and version of the data reduction proxy protocol to use.
   // Both live on the IO thread.
   std::string client_;
   std::string version_;
 
+  // The last time the session was updated. Used to ensure that a session is
+  // never used for more than twenty-four hours.
+  base::Time last_update_time_;
+
   DataReductionProxyParams* data_reduction_proxy_params_;
 
   scoped_refptr<base::SingleThreadTaskRunner> network_task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxyAuthRequestHandler);
 };
 
 }  // namespace data_reduction_proxy
 #endif  // COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_AUTH_REQUEST_HANDLER_H_