Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 465523002: De-parameterize SkNextDatumFunction. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

De-parameterize SkNextDatumFunction. Just a simple refactor to make it clear we're only using this one method and this one type. BUG=skia: Committed: https://skia.googlesource.com/skia/+/534cc4c569d88c1cfa5f10d3ecf475a90278f597

Patch Set 1 #

Patch Set 2 : no <T> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -69 lines) Patch
M src/core/SkBBHFactory.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/core/SkTileGrid.h View 2 chunks +1 line, -60 lines 0 comments Download
M src/core/SkTileGrid.cpp View 1 4 chunks +40 lines, -5 lines 0 comments Download
M tests/TileGridTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
Going to take small steps here.
6 years, 4 months ago (2014-08-11 17:01:15 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-11 17:01:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/465523002/20001
6 years, 4 months ago (2014-08-11 17:02:12 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-11 17:02:12 UTC) #4
robertphillips
lgtm
6 years, 4 months ago (2014-08-11 17:04:22 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 17:09:43 UTC) #6
Message was sent while issue was closed.
Change committed as 534cc4c569d88c1cfa5f10d3ecf475a90278f597

Powered by Google App Engine
This is Rietveld 408576698