Issue 46523002: Fix Telemetry.

Issue 46523002: Fix Telemetry. (Closed)

Created:
7 years, 1 month ago by tonyg

Modified:
7 years, 1 month ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, jochen+watch_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, arv+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, android-webview-reviews_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Telemetry. "Introduce DevToolsTargetImpl" breaks Telemetry because it no longer returns type: "other" for prerenders. "Add URL query parameter" had to go because it builds atop the broken change. BUG=311652 TBR=kaznacheev@chromium.org NOTRY=True Revert "DevTools: Add URL query parameter to json/new command" This reverts commit 296d770a744a554751bca5bdf16e681bb8615589. Revert "DevTools: Introduce DevToolsTargetImpl to unify debug target across several places in Chrome" This reverts commit 329082e9edfe5a0e5672250abc269a66ba33bdf1. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231180

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+679 lines, -831 lines)			Patch
M	android_webview/native/aw_dev_tools_server.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/android/dev_tools_server.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/devtools/browser_list_tabcontents_provider.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/devtools/browser_list_tabcontents_provider.cc	View	6 chunks	+184 lines, -10 lines	0 comments	Download
M	chrome/browser/devtools/devtools_adb_bridge.h	View	7 chunks	+54 lines, -18 lines	0 comments	Download
M	chrome/browser/devtools/devtools_adb_bridge.cc	View	14 chunks	+99 lines, -183 lines	0 comments	Download
M	chrome/browser/devtools/devtools_sanity_browsertest.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
D	chrome/browser/devtools/devtools_target_impl.h	View	1 chunk	+0 lines, -84 lines	0 comments	Download
D	chrome/browser/devtools/devtools_target_impl.cc	View	1 chunk	+0 lines, -344 lines	0 comments	Download
M	chrome/browser/devtools/port_forwarding_controller.cc	View	3 chunks	+16 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/inspect/inspect.js	View	7 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/webui/inspect_ui.h	View	3 chunks	+9 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/webui/inspect_ui.cc	View	16 chunks	+284 lines, -132 lines	0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/test/data/devtools/target_list/background.js	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	content/browser/devtools/devtools_http_handler_impl.cc	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	content/browser/devtools/devtools_http_handler_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/devtools_http_handler_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/browser/shell_devtools_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/shell/browser/shell_devtools_delegate.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/46523002/1

7 years, 1 month ago (2013-10-26 01:11:27 UTC) #1

Message was sent while issue was closed.

Change committed as 231180

Expand Messages | Collapse Messages