Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 46523002: Fix Telemetry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_impl.cc
diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc
index cd6cf8f2f0c1428a1ed7478e006a30c4ab5d5535..bdea96fbf2d67087b423ef833f7c7ae874792272 100644
--- a/content/browser/devtools/devtools_http_handler_impl.cc
+++ b/content/browser/devtools/devtools_http_handler_impl.cc
@@ -425,12 +425,9 @@ void DevToolsHttpHandlerImpl::OnJsonRequestUI(
std::string path = info.path.substr(5);
// Trim fragment and query
- std::string query;
size_t query_pos = path.find("?");
- if (query_pos != std::string::npos) {
- query = path.substr(query_pos + 1);
+ if (query_pos != std::string::npos)
path = path.substr(0, query_pos);
- }
size_t fragment_pos = path.find("#");
if (fragment_pos != std::string::npos)
@@ -467,11 +464,7 @@ void DevToolsHttpHandlerImpl::OnJsonRequestUI(
}
if (command == "new") {
- GURL url(net::UnescapeURLComponent(
- query, net::UnescapeRule::URL_SPECIAL_CHARS));
- if (!url.is_valid())
- url = GURL(kAboutBlankURL);
- scoped_ptr<DevToolsTarget> target(delegate_->CreateNewTarget(url));
+ scoped_ptr<DevToolsTarget> target(delegate_->CreateNewTarget());
if (!target) {
SendJson(connection_id,
net::HTTP_INTERNAL_SERVER_ERROR,
« no previous file with comments | « chrome/test/data/devtools/target_list/background.js ('k') | content/browser/devtools/devtools_http_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698