[Telemetry] Remove arbitrary sleep in record_wpr.

tools/telemetry/telemetry/page/record_wpr.py

-#!/usr/bin/env python

[dtu, 2014/08/13 05:47:07]

Might have to disable executable bit?

[tonyg, 2014/08/13 05:51:34]

I did. The unified diff shows the permissions change.

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
+
 import logging
 import sys
-import time
 
 from telemetry import benchmark
 from telemetry.core import browser_options
 from telemetry.core import discover
 from telemetry.core import wpr_modes
 from telemetry.page import page_runner
 from telemetry.page import page_set
 from telemetry.page import page_test
 from telemetry.page import profile_creator
 from telemetry.page import test_expectations
+from telemetry.core import util

[dtu, 2014/08/13 05:47:07]

out of order

[tonyg, 2014/08/13 05:51:34]

Oops, fixed.

 from telemetry.results import results_options
 
 
 class RecorderPageTest(page_test.PageTest):  # pylint: disable=W0223
   def __init__(self, action_names):
     super(RecorderPageTest, self).__init__()
     self._action_names = action_names
     self.page_test = None
 
   def CanRunForPage(self, page):
@@ skipping 17 matching lines @@
   def DidRunActions(self, page, tab):
     if self.page_test:
       self.page_test.DidRunActions(page, tab)
 
   def ValidateAndMeasurePage(self, page, tab, results):
     if self.page_test:
       self.page_test.ValidateAndMeasurePage(page, tab, results)
 
   def RunPage(self, page, tab, results):
     tab.WaitForDocumentReadyStateToBeComplete()
-
-    # When recording, sleep to catch any resources that load post-onload.
-    # TODO(tonyg): This should probably monitor resource timing for activity
-    # and sleep until 2s since the last network event with some timeout like
-    # 20s. We could wrap this up as WaitForNetworkIdle() and share with the
-    # speed index metric.
-    time.sleep(3)
+    util.WaitFor(tab.HasReachedQuiescence, 30)

[dtu, 2014/08/13 05:47:07]

30 is too long for the unit tests

[tonyg, 2014/08/13 05:51:34]

They don't get anywhere near this because the simple page quiesces so quickly.
The longer timeout is so that recording real-world pages can wait until they
quiesce.

 
     if self.page_test:
       self._action_name_to_run = self.page_test.action_name_to_run
       self.page_test.RunPage(page, tab, results)
       return
 
     should_reload = False
     # Run the actions on the page for all available measurements.
     for action_name in self._action_names:
       # Skip this action if it is not defined
@@ skipping 116 matching lines @@
   quick_args = [a for a in sys.argv[1:] if not a.startswith('-')]
   if len(quick_args) != 1:
     print >> sys.stderr, 'Usage: record_wpr <PageSet|Benchmark>\n'
     sys.exit(1)
   target = quick_args.pop()
   wpr_recorder = WprRecorder(base_dir, target)
   results = wpr_recorder.CreateResults()
   wpr_recorder.Record(results)
   wpr_recorder.HandleResults(results)
   return min(255, len(results.failures))