Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 465113002: Revert 288557 "[Sync] Use OnSingleDataTypeUnrecoverableError for..." (Closed)

Created:
6 years, 4 months ago by oshima
Modified:
6 years, 4 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 288557 "[Sync] Use OnSingleDataTypeUnrecoverableError for..." Reason for revert: see crbug.com/403098 > [Sync] Use OnSingleDataTypeUnrecoverableError for all errors > > This removes the disable callback from all datatype controllers as well > as the DisableDataType method from the PSS, in favor of > OnSingleDataTypeUnrecoverable error (which now accepts a SyncError). > > BUG=368834, 403098 > TBR=bauerb@chromium.org > > Review URL: https://codereview.chromium.org/436733002 TBR=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -285 lines) Patch
M trunk/src/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/autofill_profile_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/bookmark_change_processor.cc View 9 chunks +20 lines, -50 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/bookmark_model_associator.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/device_info_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/device_info_data_type_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/device_info_data_type_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/extension_backed_data_type_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/extension_backed_data_type_controller.cc View 3 chunks +11 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/extension_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/extension_data_type_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/extension_setting_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/frontend_data_type_controller.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/frontend_data_type_controller.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/non_frontend_data_type_controller.h View 2 chunks +5 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/non_frontend_data_type_controller.cc View 4 chunks +26 lines, -22 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/password_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/password_data_type_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/search_engine_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/search_engine_data_type_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/search_engine_data_type_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/theme_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/theme_data_type_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/glue/typed_url_change_processor.cc View 5 chunks +44 lines, -32 lines 0 comments Download
M trunk/src/chrome/browser/sync/glue/typed_url_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/profile_sync_components_factory_impl.cc View 16 chunks +63 lines, -18 lines 0 comments Download
M trunk/src/chrome/browser/sync/profile_sync_service.h View 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/sync/profile_sync_service.cc View 3 chunks +20 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/sessions/session_data_type_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/sessions/session_data_type_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/sync/sessions/session_data_type_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/components/sync_driver/change_processor_mock.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/components/sync_driver/data_type_controller.h View 2 chunks +6 lines, -1 line 0 comments Download
M trunk/src/components/sync_driver/data_type_controller.cc View 2 chunks +8 lines, -1 line 0 comments Download
M trunk/src/components/sync_driver/data_type_error_handler.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/components/sync_driver/data_type_error_handler_mock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/components/sync_driver/fake_data_type_controller.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/components/sync_driver/fake_data_type_controller.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M trunk/src/components/sync_driver/generic_change_processor.cc View 18 chunks +52 lines, -31 lines 0 comments Download
M trunk/src/components/sync_driver/model_association_manager_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/components/sync_driver/non_ui_data_type_controller.h View 3 chunks +6 lines, -3 lines 0 comments Download
M trunk/src/components/sync_driver/non_ui_data_type_controller.cc View 4 chunks +13 lines, -8 lines 0 comments Download
M trunk/src/components/sync_driver/non_ui_data_type_controller_mock.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/components/sync_driver/non_ui_data_type_controller_unittest.cc View 6 chunks +20 lines, -8 lines 0 comments Download
M trunk/src/components/sync_driver/proxy_data_type_controller.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/components/sync_driver/proxy_data_type_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/components/sync_driver/ui_data_type_controller.h View 2 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/components/sync_driver/ui_data_type_controller.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/components/sync_driver/ui_data_type_controller_unittest.cc View 4 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
oshima
6 years, 4 months ago (2014-08-12 23:29:04 UTC) #1
oshima
6 years, 4 months ago (2014-08-12 23:29:14 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r289113.

Powered by Google App Engine
This is Rietveld 408576698