Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 436733002: [Sync] Use OnSingleDataTypeUnrecoverableError for all errors (Closed)

Created:
6 years, 4 months ago by Nicolas Zea
Modified:
6 years, 4 months ago
Reviewers:
haitaol1
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, benquan, haitaol+watch_chromium.org, pam+watch_chromium.org, Dane Wallinga, dyu1, chromium-apps-reviews_chromium.org, mkwst+watchlist_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Sync] Use OnSingleDataTypeUnrecoverableError for all errors This removes the disable callback from all datatype controllers as well as the DisableDataType method from the PSS, in favor of OnSingleDataTypeUnrecoverable error (which now accepts a SyncError). BUG=368834 TBR=bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288557

Patch Set 1 #

Patch Set 2 : More cleanup #

Total comments: 11

Patch Set 3 : Address comments #

Patch Set 4 : Address comments #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -482 lines) Patch
M chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 2 9 chunks +50 lines, -20 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/device_info_data_type_controller.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/device_info_data_type_controller.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/device_info_data_type_controller_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/extension_backed_data_type_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_backed_data_type_controller.cc View 1 3 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.cc View 1 2 3 6 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.h View 1 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.cc View 1 2 3 4 chunks +22 lines, -26 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/search_engine_data_type_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/search_engine_data_type_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/search_engine_data_type_controller_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 5 chunks +32 lines, -44 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 2 3 4 16 chunks +18 lines, -63 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 3 4 3 chunks +7 lines, -20 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/session_data_type_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/sessions/session_data_type_controller.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/sessions/session_data_type_controller_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync_driver/change_processor_mock.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync_driver/data_type_controller.h View 2 chunks +1 line, -6 lines 0 comments Download
M components/sync_driver/data_type_controller.cc View 2 chunks +1 line, -8 lines 0 comments Download
M components/sync_driver/data_type_error_handler.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync_driver/data_type_error_handler_mock.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_driver/fake_data_type_controller.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync_driver/fake_data_type_controller.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download
M components/sync_driver/generic_change_processor.cc View 1 18 chunks +31 lines, -52 lines 0 comments Download
M components/sync_driver/model_association_manager_unittest.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M components/sync_driver/non_ui_data_type_controller.h View 1 3 chunks +3 lines, -6 lines 0 comments Download
M components/sync_driver/non_ui_data_type_controller.cc View 1 2 3 4 chunks +8 lines, -13 lines 0 comments Download
M components/sync_driver/non_ui_data_type_controller_mock.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync_driver/non_ui_data_type_controller_unittest.cc View 1 6 chunks +8 lines, -20 lines 0 comments Download
M components/sync_driver/proxy_data_type_controller.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/sync_driver/proxy_data_type_controller.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync_driver/ui_data_type_controller.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M components/sync_driver/ui_data_type_controller.cc View 1 2 3 5 chunks +8 lines, -8 lines 0 comments Download
M components/sync_driver/ui_data_type_controller_unittest.cc View 1 2 3 4 4 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Nicolas Zea
+Haitao, PTAL.
6 years, 4 months ago (2014-08-04 21:56:40 UTC) #1
Nicolas Zea
ping?
6 years, 4 months ago (2014-08-06 21:19:29 UTC) #2
haitaol1
https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/bookmark_change_processor.cc File chrome/browser/sync/glue/bookmark_change_processor.cc (right): https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/bookmark_change_processor.cc#newcode281 chrome/browser/sync/glue/bookmark_change_processor.cc:281: empty line https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/frontend_data_type_controller.cc File chrome/browser/sync/glue/frontend_data_type_controller.cc (right): https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/frontend_data_type_controller.cc#newcode152 chrome/browser/sync/glue/frontend_data_type_controller.cc:152: if ...
6 years, 4 months ago (2014-08-07 00:49:49 UTC) #3
haitaol1
https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/bookmark_change_processor.cc File chrome/browser/sync/glue/bookmark_change_processor.cc (right): https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/bookmark_change_processor.cc#newcode281 chrome/browser/sync/glue/bookmark_change_processor.cc:281: empty line https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/frontend_data_type_controller.cc File chrome/browser/sync/glue/frontend_data_type_controller.cc (right): https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/frontend_data_type_controller.cc#newcode152 chrome/browser/sync/glue/frontend_data_type_controller.cc:152: if ...
6 years, 4 months ago (2014-08-07 00:49:49 UTC) #4
Nicolas Zea
PTAL https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/bookmark_change_processor.cc File chrome/browser/sync/glue/bookmark_change_processor.cc (right): https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/bookmark_change_processor.cc#newcode281 chrome/browser/sync/glue/bookmark_change_processor.cc:281: On 2014/08/07 00:49:48, haitaol1 wrote: > empty line ...
6 years, 4 months ago (2014-08-07 18:14:54 UTC) #5
haitaol1
https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/frontend_data_type_controller.cc File chrome/browser/sync/glue/frontend_data_type_controller.cc (right): https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/frontend_data_type_controller.cc#newcode152 chrome/browser/sync/glue/frontend_data_type_controller.cc:152: if (!start_callback_.is_null()) { But on line 290 below, start_callback_ ...
6 years, 4 months ago (2014-08-07 18:24:15 UTC) #6
Nicolas Zea
https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/frontend_data_type_controller.cc File chrome/browser/sync/glue/frontend_data_type_controller.cc (right): https://codereview.chromium.org/436733002/diff/20001/chrome/browser/sync/glue/frontend_data_type_controller.cc#newcode152 chrome/browser/sync/glue/frontend_data_type_controller.cc:152: if (!start_callback_.is_null()) { On 2014/08/07 18:24:15, haitaol1 wrote: > ...
6 years, 4 months ago (2014-08-07 22:50:19 UTC) #7
haitaol1
lgtm
6 years, 4 months ago (2014-08-08 17:34:31 UTC) #8
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-08 23:22:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/436733002/80001
6 years, 4 months ago (2014-08-08 23:26:06 UTC) #10
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-08 23:46:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/436733002/100001
6 years, 4 months ago (2014-08-08 23:49:45 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 10:33:24 UTC) #13
Message was sent while issue was closed. 
Change committed as 288557

Powered by Google App Engine
This is Rietveld 408576698