Add entry point for passing options to the GrContextFactory

Add entry point for passing options to the GrContextFactory

Committed: https://skia.googlesource.com/skia/+/69a5560ea5a8d26b120f5158e506a163d32b4a27

[bsalomon, 2014-08-13 00:49:33]

https://codereview.chromium.org/465073002/diff/1/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/465073002/diff/1/bench/nanobench.cpp#newcode30
bench/nanobench.cpp:30: #endif
Maybe just make this the autotdelete? I think it has overloaded ->

[robertphillips, 2014-08-13 13:59:29]

https://codereview.chromium.org/465073002/diff/1/include/gpu/GrContextFactory.h
File include/gpu/GrContextFactory.h (right):

https://codereview.chromium.org/465073002/diff/1/include/gpu/GrContextFactory...
include/gpu/GrContextFactory.h:91: explicit GrContextFactory(const
GrContext::Options& opts) : fGlobalOptions(opts) { }
Won't default ctor just fire here?

https://codereview.chromium.org/465073002/diff/1/include/gpu/GrContextFactory...
include/gpu/GrContextFactory.h:210: };
Line 'fContexts' up with 'fGlobalOptions' ?

[krajcevski, 2014-08-13 14:46:00]

https://codereview.chromium.org/465073002/diff/1/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/465073002/diff/1/bench/nanobench.cpp#newcode30
bench/nanobench.cpp:30: #endif
On 2014/08/13 00:49:33, bsalomon wrote:
> Maybe just make this the autotdelete? I think it has overloaded ->

Done.

https://codereview.chromium.org/465073002/diff/1/include/gpu/GrContextFactory.h
File include/gpu/GrContextFactory.h (right):

https://codereview.chromium.org/465073002/diff/1/include/gpu/GrContextFactory...
include/gpu/GrContextFactory.h:91: explicit GrContextFactory(const
GrContext::Options& opts) : fGlobalOptions(opts) { }
On 2014/08/13 13:59:29, robertphillips wrote:
> Won't default ctor just fire here?

Yes, C++ is great. :(

https://codereview.chromium.org/465073002/diff/1/include/gpu/GrContextFactory...
include/gpu/GrContextFactory.h:210: };
On 2014/08/13 13:59:29, robertphillips wrote:
> Line 'fContexts' up with 'fGlobalOptions' ?

Done.

[robertphillips, 2014-08-13 16:08:22]

lgtm, Brian?

[bsalomon, 2014-08-13 17:28:20]

On 2014/08/13 16:08:22, robertphillips wrote:
> lgtm, Brian?

lgtm

[krajcevski, 2014-08-13 17:30:12]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-08-13 17:31:14]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/465073002/20001

[commit-bot: I haz the power, 2014-08-13 17:46:35]

Committed patchset #2 (20001) as 69a5560ea5a8d26b120f5158e506a163d32b4a27