Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: Tools/GardeningServer/ui/ct-failure-stream.html

Issue 464963003: Move commit list out its own model. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-failure-stream.html
diff --git a/Tools/GardeningServer/ui/ct-failure-stream.html b/Tools/GardeningServer/ui/ct-failure-stream.html
index a3412be0626816c3c76ccc9c4a970fa743ac2576..06f84304fab903d35278c29ce2b8f8a83b674cfb 100644
--- a/Tools/GardeningServer/ui/ct-failure-stream.html
+++ b/Tools/GardeningServer/ui/ct-failure-stream.html
@@ -5,8 +5,9 @@ found in the LICENSE file.
-->
<link rel="import" href="ct-failure-card.html">
+<link rel="import" href="../model/ct-commit-list.html">
-<polymer-element name="ct-failure-stream" attributes="groups commits tree" noscript>
+<polymer-element name="ct-failure-stream" attributes="groups commits tree">
<template>
<style>
:host {
@@ -20,7 +21,14 @@ found in the LICENSE file.
}
</style>
<template repeat="{{ group in groups }}">
- <ct-failure-card group="{{ group }}" commits="{{ commits }}" tree="{{ tree }}"></ct-failure-card>
+ <ct-failure-card group="{{ group }}" commitList="{{ _commitList(group) }}" tree="{{ tree }}"></ct-failure-card>
</template>
</template>
+ <script>
+ Polymer({
+ _commitList: function(group) {
+ return new CTCommitList(group, this.commits);
ojan 2014/08/12 21:08:36 Not sure if it's better, but CTFailureGroup could
dsinclair 2014/08/15 14:05:04 Done.
+ }
+ });
+ </script>
</polymer-element>

Powered by Google App Engine
This is Rietveld 408576698