Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2944)

Unified Diff: Tools/GardeningServer/ui/ct-failure-card.html

Issue 464963003: Move commit list out its own model. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-failure-card.html
diff --git a/Tools/GardeningServer/ui/ct-failure-card.html b/Tools/GardeningServer/ui/ct-failure-card.html
index 7bf9f799d6ce025670efbd5dec89bfcb397478e8..97c50ae576a6070f4f2452c90efce3f498ddafed 100644
--- a/Tools/GardeningServer/ui/ct-failure-card.html
+++ b/Tools/GardeningServer/ui/ct-failure-card.html
@@ -8,7 +8,7 @@ found in the LICENSE file.
<link rel="import" href="ct-commit-list.html">
<link rel="import" href="ct-test-list.html">
-<polymer-element name="ct-failure-card" attributes="group commits tree">
+<polymer-element name="ct-failure-card" attributes="group commitList tree">
<template>
<style>
:host {
@@ -63,9 +63,7 @@ found in the LICENSE file.
<ct-builder-grid failures="{{ group.failures }}"></ct-builder-grid>
<div class="{{ { failure: true, snoozed: group.isSnoozed } | tokenList }}">
<ct-test-list tests="{{ group.failures }}" tree="{{ tree }}"></ct-test-list>
- <ct-commit-list first="{{ group.failures[0].lastPassingRevisions }}"
- last="{{ group.failures[0].firstFailingRevisions }}"
- commits="{{ commits }}"></ct-commit-list>
+ <ct-commit-list commitList="{{ commitList }}"></ct-commit-list>
</div>
<paper-button id="examine" on-tap="{{ examine }}">Examine</paper-button>
<template if="{{ !group.isSnoozed }}">
@@ -78,7 +76,7 @@ found in the LICENSE file.
<script>
Polymer({
group: null,
- commits: {},
+ commitList: null,
tree: '',
examine: function() {

Powered by Google App Engine
This is Rietveld 408576698