Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 464963002: DevTools: Make UISourceCode Target-agnostic (Closed)

Created:
6 years, 4 months ago by apavlov
Modified:
6 years, 4 months ago
Reviewers:
vsevik, sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Make UISourceCode Target-agnostic The presence of Target-related mappings in UISC is a severe dependency violation. This patch moves those mappings into DebuggerWorkspaceBinding. R=pfeldman, sergeyv, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180159

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -182 lines) Patch
M LayoutTests/http/tests/inspector/compiler-script-mapping.html View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/breakpoint-manager.html View 3 chunks +2 lines, -3 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/breakpoint-manager.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/file-system-project-mapping.html View 5 chunks +17 lines, -14 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/multi-target-breakpoint-manager.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/resource-script-mapping.html View 8 chunks +10 lines, -11 lines 0 comments Download
M Source/devtools/front_end/sdk/BreakpointManager.js View 2 chunks +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/CompilerScriptMapping.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js View 1 8 chunks +125 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/DefaultScriptMapping.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/LiveEditSupport.js View 1 chunk +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/ResourceScriptMapping.js View 1 7 chunks +54 lines, -11 lines 0 comments Download
M Source/devtools/front_end/sdk/ScriptSnippetModel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/UISourceCode.js View 5 chunks +0 lines, -119 lines 0 comments Download
M Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 5 chunks +7 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/ScriptFormatterEditorAction.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
apavlov
6 years, 4 months ago (2014-08-12 17:32:25 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-12 17:53:56 UTC) #2
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-12 17:59:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/464963002/1
6 years, 4 months ago (2014-08-12 18:00:42 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-12 19:40:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 20:12:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22359)
6 years, 4 months ago (2014-08-12 20:12:47 UTC) #7
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 4 months ago (2014-08-13 07:01:33 UTC) #8
vsevik
https://chromiumcodereview.appspot.com/464963002/diff/1/Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js File Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js (right): https://chromiumcodereview.appspot.com/464963002/diff/1/Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js#newcode296 Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js:296: this._uiSourceCodeToSourceMapping = new Map(); This map is never cleared. ...
6 years, 4 months ago (2014-08-13 07:02:04 UTC) #9
vsevik
The CQ bit was unchecked by vsevik@chromium.org
6 years, 4 months ago (2014-08-13 07:02:09 UTC) #10
apavlov
https://chromiumcodereview.appspot.com/464963002/diff/1/Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js File Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js (right): https://chromiumcodereview.appspot.com/464963002/diff/1/Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js#newcode296 Source/devtools/front_end/sdk/DebuggerWorkspaceBinding.js:296: this._uiSourceCodeToSourceMapping = new Map(); On 2014/08/13 07:02:04, vsevik wrote: ...
6 years, 4 months ago (2014-08-13 07:20:44 UTC) #11
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 4 months ago (2014-08-13 07:23:20 UTC) #12
vsevik
lgtm
6 years, 4 months ago (2014-08-13 07:23:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/464963002/20001
6 years, 4 months ago (2014-08-13 07:24:25 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 08:22:34 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 09:18:44 UTC) #16
Message was sent while issue was closed. 
Change committed as 180159

Powered by Google App Engine
This is Rietveld 408576698