Source/devtools/front_end/sdk/BreakpointManager.js - Issue 464963002: DevTools: Make UISourceCode Target-agnostic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sdk/BreakpointManager.js

Issue 464963002: DevTools: Make UISourceCode Target-agnostic (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/sdk/BreakpointManager.js

diff --git a/Source/devtools/front_end/sdk/BreakpointManager.js b/Source/devtools/front_end/sdk/BreakpointManager.js

index 185371ae66459c782291cba40325f0603f2a49e8..3d092b2d691800932bfe5286d68528387123513d 100644

--- a/Source/devtools/front_end/sdk/BreakpointManager.js

+++ b/Source/devtools/front_end/sdk/BreakpointManager.js

@@ -95,7 +95,6 @@ WebInspector.BreakpointManager.prototype = {

targetRemoved: function(target) { },

/**

* @param {string} sourceFileId

* @return {!StringMap.<!WebInspector.BreakpointManager.Breakpoint>}

@@ -775,7 +774,7 @@ WebInspector.BreakpointManager.TargetBreakpoint.prototype = {

var uiSourceCode = this._breakpoint.uiSourceCode();

if (!uiSourceCode)

return false;

- var scriptFile = uiSourceCode.scriptFileForTarget(this.target());

+ var scriptFile = this._debuggerWorkspaceBinding.scriptFile(uiSourceCode, this.target());

return !!scriptFile && scriptFile.hasDivergedFromVM();