Accept invalid Schemas for the managed storage API.

chrome/browser/extensions/api/storage/managed_value_store_cache.cc

Index: chrome/browser/extensions/api/storage/managed_value_store_cache.cc
diff --git a/chrome/browser/extensions/api/storage/managed_value_store_cache.cc b/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
index c9e9f4a4a4c08a0c8c6c464f0c30328cb8f01d94..070a2f74730a18393efafaf5004d0d84d6bd6c6b 100644
--- a/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
+++ b/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
@@ -206,7 +206,6 @@ void ManagedValueStoreCache::ExtensionTracker::LoadSchemasOnBlockingPool(
     std::string error;
     policy::Schema schema =
         StorageSchemaManifestHandler::GetSchema(it->get(), &error);
-    CHECK(schema.valid()) << error;
     (*components)[(*it)->id()] = schema;

[not at google - send to devlin, 2014/08/12 20:13:17]

Now you'll be adding a potentially invalid schema to |components|. Is that what
you want?

[Joao da Silva, 2014/08/13 10:05:03]

Not quite, thanks for pointing this out :-) What we want in this case is an
empty schema: the extension is still in the policy registry and will show up in
chrome://policy (and the chrome.storage.managed API exists) but it won't be able
to load any policies.

   }