Accept invalid Schemas for the managed storage API.

chrome/browser/extensions/api/storage/managed_value_store_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/storage/managed_value_store_cache.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/file_util.h"
@@ skipping 188 matching lines @@
             manifest_keys::kStorageManagedSchema, &schema_file)) {
       // TODO(joaodasilva): Remove this. http://crbug.com/325349
       (*components)[(*it)->id()] = policy::Schema();
       continue;
     }
     // The extension should have been validated, so assume the schema exists
     // and is valid.
     std::string error;
     policy::Schema schema =
         StorageSchemaManifestHandler::GetSchema(it->get(), &error);
-    CHECK(schema.valid()) << error;
     (*components)[(*it)->id()] = schema;

[not at google - send to devlin, 2014/08/12 20:13:17]

Now you'll be adding a potentially invalid schema to |components|. Is that what
you want?

[Joao da Silva, 2014/08/13 10:05:03]

Not quite, thanks for pointing this out :-) What we want in this case is an
empty schema: the extension is still in the policy registry and will show up in
chrome://policy (and the chrome.storage.managed API exists) but it won't be able
to load any policies.

   }
 
   BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
                           base::Bind(&ExtensionTracker::Register, self,
                                      base::Owned(components.release())));
 }
 
 void ManagedValueStoreCache::ExtensionTracker::Register(
     const policy::ComponentMap* components) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ skipping 144 matching lines @@
 
   return store;
 }
 
 bool ManagedValueStoreCache::HasStore(const std::string& extension_id) const {
   // TODO(joaodasilva): move this check to a ValueStore method.
   return base::DirectoryExists(base_path_.AppendASCII(extension_id));
 }
 
 }  // namespace extensions