Fix HidService lifetime issues.

device/hid/hid_connection_unittest.cc

Index: device/hid/hid_connection_unittest.cc
diff --git a/device/hid/hid_connection_unittest.cc b/device/hid/hid_connection_unittest.cc
index eb973f776e0d831ac70be7081e35e9b1fde2f0ad..0c744c81ec3e17919d3255c02f76e174039a38b8 100644
--- a/device/hid/hid_connection_unittest.cc
+++ b/device/hid/hid_connection_unittest.cc
@@ -56,7 +56,8 @@ class HidConnectionTest : public testing::Test {
     if (!UsbTestGadget::IsTestEnabled()) return;
 
     message_loop_.reset(new base::MessageLoopForIO());
-    service_.reset(HidService::Create(message_loop_->message_loop_proxy()));
+    service_.reset(HidService::GetInstance(
+        message_loop_->message_loop_proxy()));

[Reilly Grant (use Gerrit), 2014/08/12 17:12:17]

This line points out exactly what I'm going to need to fix in these tests: The
message loop created above is a MessageLoopForIO but what HidService really
wants is a MessageLoopForUI. It's okay for now but once I fix these tests to
create two separate message loops we may want to put checks in
HidService::GetInstance to be sure that the message loop provided is of the
right type.

     ASSERT_TRUE(service_);
 
     test_gadget_ = UsbTestGadget::Claim();