Fix HidService lifetime issues.

device/hid/hid_connection_unittest.cc

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 38 matching lines @@
 };
 
 }  // namespace
 
 class HidConnectionTest : public testing::Test {
  protected:
   virtual void SetUp() OVERRIDE {
     if (!UsbTestGadget::IsTestEnabled()) return;
 
     message_loop_.reset(new base::MessageLoopForIO());
-    service_.reset(HidService::Create(message_loop_->message_loop_proxy()));
+    service_.reset(HidService::GetInstance(
+        message_loop_->message_loop_proxy()));

[Reilly Grant (use Gerrit), 2014/08/12 17:12:17]

This line points out exactly what I'm going to need to fix in these tests: The
message loop created above is a MessageLoopForIO but what HidService really
wants is a MessageLoopForUI. It's okay for now but once I fix these tests to
create two separate message loops we may want to put checks in
HidService::GetInstance to be sure that the message loop provided is of the
right type.

     ASSERT_TRUE(service_);
 
     test_gadget_ = UsbTestGadget::Claim();
     ASSERT_TRUE(test_gadget_);
     ASSERT_TRUE(test_gadget_->SetType(UsbTestGadget::HID_ECHO));
 
     device_id_ = kInvalidHidDeviceId;
 
     base::RunLoop run_loop;
     message_loop_->PostDelayedTask(
@@ skipping 54 matching lines @@
     scoped_refptr<IOBufferWithSize> read_buffer(new IOBufferWithSize(8));
     TestCompletionCallback read_callback;
     conn->Read(read_buffer, read_callback.callback());
     ASSERT_TRUE(read_callback.WaitForResult());
     ASSERT_EQ(8UL, read_callback.transferred());
     ASSERT_EQ(i, *(int64_t*)read_buffer->data());
   }
 }
 
 }  // namespace device