WebView unit tests for Defect 248426

The objective of this test to assert text returned from a SelectAll call on WebContent is same as text from WebLocalFrame::ContentAsText.

This is a patch that refers to the following CL
https://codereview.chromium.org/342143004/

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180208

[sarka, 2014-08-12 02:06:30]

Uploaded a test as per reviewers requests in CL 
https://codereview.chromium.org/342143004/
PTAL
Thanks

[jamesr, 2014-08-12 23:34:16]

The patch description isn't very good.  See:

http://www.chromium.org/developers/contributing-code#TOC-Change-List-Descript...

https://codereview.chromium.org/464613003/diff/1/Source/web/tests/WebViewTest...
File Source/web/tests/WebViewTest.cpp (right):

https://codereview.chromium.org/464613003/diff/1/Source/web/tests/WebViewTest...
Source/web/tests/WebViewTest.cpp:2141: TEST_F(WebViewTest,
OnTTSUtteranceForNoSelection)
this test doesn't have anything to do with TTS. it appears to be testing the
behavior of execCommand('SelectAll') and selectionAsText(). please update the
name accordingly

https://codereview.chromium.org/464613003/diff/1/Source/web/tests/WebViewTest...
Source/web/tests/WebViewTest.cpp:2148: // contentAsText().
none of this comment has anything to do with what the test actually does, it's
just transient information. this belongs in the commit message, not the code

https://codereview.chromium.org/464613003/diff/1/Source/web/tests/WebViewTest...
Source/web/tests/WebViewTest.cpp:2157: std::string output1 =
frame->selectionAsText().utf8();
output1 isn't a very useful variable name. what does this represent? maybe
'actual' vs 'expected' ?

[sarka, 2014-08-13 18:50:44]

On 2014/08/12 23:34:16, jamesr wrote:
> The patch description isn't very good.  See:
> 
>
http://www.chromium.org/developers/contributing-code#TOC-Change-List-Descript...
> 
>
https://codereview.chromium.org/464613003/diff/1/Source/web/tests/WebViewTest...
> File Source/web/tests/WebViewTest.cpp (right):
> 
>
https://codereview.chromium.org/464613003/diff/1/Source/web/tests/WebViewTest...
> Source/web/tests/WebViewTest.cpp:2141: TEST_F(WebViewTest,
> OnTTSUtteranceForNoSelection)
> this test doesn't have anything to do with TTS. it appears to be testing the
> behavior of execCommand('SelectAll') and selectionAsText(). please update the
> name accordingly
> 
Done
>
https://codereview.chromium.org/464613003/diff/1/Source/web/tests/WebViewTest...
> Source/web/tests/WebViewTest.cpp:2148: // contentAsText().
> none of this comment has anything to do with what the test actually does, it's
> just transient information. this belongs in the commit message, not the code
> 
Done
>
https://codereview.chromium.org/464613003/diff/1/Source/web/tests/WebViewTest...
> Source/web/tests/WebViewTest.cpp:2157: std::string output1 =
> frame->selectionAsText().utf8();
> output1 isn't a very useful variable name. what does this represent? maybe
> 'actual' vs 'expected' ?
Done

PTAL.
Thanks

[jamesr, 2014-08-13 19:07:48]

https://codereview.chromium.org/464613003/diff/20001/Source/web/tests/WebView...
File Source/web/tests/WebViewTest.cpp (right):

https://codereview.chromium.org/464613003/diff/20001/Source/web/tests/WebView...
Source/web/tests/WebViewTest.cpp:2152: EXPECT_EQ(exptected, actual);
typo 'exptected' -> 'expected'

[sarka, 2014-08-13 19:13:40]

On 2014/08/13 19:07:48, jamesr wrote:
>
https://codereview.chromium.org/464613003/diff/20001/Source/web/tests/WebView...
> File Source/web/tests/WebViewTest.cpp (right):
> 
>
https://codereview.chromium.org/464613003/diff/20001/Source/web/tests/WebView...
> Source/web/tests/WebViewTest.cpp:2152: EXPECT_EQ(exptected, actual);
> typo 'exptected' -> 'expected'

Done.

PTAL.

Thanks

[jamesr, 2014-08-13 19:28:48]

The CQ bit was checked by jamesr@chromium.org

[jamesr, 2014-08-13 19:28:48]

lgtm

[commit-bot: I haz the power, 2014-08-13 19:30:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/a.sarkar.arun@gmail.com/464613003/40001

[commit-bot: I haz the power, 2014-08-13 22:22:05]

Committed patchset #3 (40001) as 180208