WebView unit tests for Defect 248426

Source/web/tests/WebViewTest.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 48 matching lines @@
 #include "public/web/WebAutofillClient.h"
 #include "public/web/WebContentDetectionResult.h"
 #include "public/web/WebDateTimeChooserCompletion.h"
 #include "public/web/WebDocument.h"
 #include "public/web/WebDragOperation.h"
 #include "public/web/WebElement.h"
 #include "public/web/WebFrame.h"
 #include "public/web/WebFrameClient.h"
 #include "public/web/WebHitTestResult.h"
 #include "public/web/WebInputEvent.h"
+#include "public/web/WebScriptSource.h"
 #include "public/web/WebSettings.h"
 #include "public/web/WebViewClient.h"
 #include "public/web/WebWidget.h"
 #include "public/web/WebWidgetClient.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkBitmapDevice.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebSettingsImpl.h"
 #include "web/WebViewImpl.h"
@@ skipping 2051 matching lines @@
     webView->setInitialFocus(false);
 
     EXPECT_EQ(0, client.getUserGestureNotificationsCount());
 
     EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureTap, WebString::fromUTF8("target")));
 
     EXPECT_EQ(1, client.getUserGestureNotificationsCount());
     webView->setAutofillClient(0);
 }
 
+TEST_F(WebViewTest, OnTTSUtteranceForNoSelection)

[jamesr, 2014/08/12 23:34:15]

this test doesn't have anything to do with TTS. it appears to be testing the
behavior of execCommand('SelectAll') and selectionAsText(). please update the
name accordingly

+{
+    // Note: This is a test to somewhat simulate a CL submitted for
+    // crbug.com/248426. Follow https://codereview.chromium.org/342143004/.
+    // As of now there is no good way to test a TTS session. Since the patch
+    // uses contentAsText() to fetch fully rendered text from a web content
+    // it is okay to check if text returned from SelectAll is same as
+    // contentAsText().

[jamesr, 2014/08/12 23:34:15]

none of this comment has anything to do with what the test actually does, it's
just transient information. this belongs in the commit message, not the code

+    // TODO(a.sarkar.arun@gmail.com): When Chromium has a better support for
+    // testing TTS extensively, this test should be improved and moved to a
+    // more appropriate place.
+    URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("longpress_selection.html"));
+    WebView* webView = m_webViewHelper.initializeAndLoad(m_baseURL + "longpress_selection.html", true);
+    WebLocalFrameImpl* frame = toWebLocalFrameImpl(webView->mainFrame());
+    frame->executeScript(WebScriptSource(WebString::fromUTF8("document.execCommand('SelectAll', false, null)")));
+
+    std::string output1 = frame->selectionAsText().utf8();

[jamesr, 2014/08/12 23:34:15]

output1 isn't a very useful variable name. what does this represent? maybe
'actual' vs 'expected' ?

+
+    const int kMaxOutputCharacters = 1024;
+    std::string output = frame->contentAsText(kMaxOutputCharacters).utf8();
+    EXPECT_EQ(output1, output);
+
+}
+
 } // namespace