Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 464543003: Set SO_REUSEADDR on layout test server sockets on non-Windows systems (Closed)

Created:
6 years, 4 months ago by jsbell
Modified:
6 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Set SO_REUSEADDR on layout test server sockets on non-Windows systems Code to set the flag was removed as part of debugging crbug.com/378444 but this causes ports to report as "in use" for some time after the test server stops, meaning that re-running layout tests with only a short delay may fail. Restore setting the flag, but scoped to non-Windows systems. BUG=378444 R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Tools/Scripts/webkitpy/layout_tests/servers/server_base.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
dpranke@ - please take a look? Per discussion over in https://codereview.chromium.org/413063002 (sorry for the delay, ...
6 years, 4 months ago (2014-08-11 18:03:14 UTC) #1
Dirk Pranke
lgtm. Sorry, I meant to get to this last week but didn't. Thanks!
6 years, 4 months ago (2014-08-11 22:18:01 UTC) #2
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 4 months ago (2014-08-11 22:28:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/464543003/1
6 years, 4 months ago (2014-08-11 22:30:05 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 22:34:17 UTC) #5
Message was sent while issue was closed.
Change committed as 180001

Powered by Google App Engine
This is Rietveld 408576698