Tools/Scripts/webkitpy/layout_tests/servers/server_base.py - Issue 464543003: Set SO_REUSEADDR on layout test server sockets on non-Windows systems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

Issue 464543003: Set SO_REUSEADDR on layout test server sockets on non-Windows systems (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py b/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

index 854a9070d075ea8d5e3dad8e6f508fae12a48a99..1d6a3e1138acf6b5700861b71c0977076879dba1 100644

--- a/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

+++ b/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

@@ -261,7 +261,8 @@ class ServerBase(object):

def _check_that_all_ports_are_available(self):

for mapping in self._mappings:

s = socket.socket()

- # s.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)

+ if not self._platform.is_win():

+ s.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)

port = mapping['port']

try:

s.bind(('localhost', port))

« no previous file with comments | « no previous file | no next file » | no next file with comments »