Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 464503003: GN: Only define UNIT_TEST in direct gtest deps (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

GN: Only define UNIT_TEST in direct gtest deps This matches the gyp build and is important for parts of the code that guard their API with UNIT_TEST. For instance, chrome/browser/ui/views/omnibox/omnibox_view_views.h has a GetRenderText function guarded by #if UNIT_TEST that shadows a protected function GetRenderText from its parent class views::Textfield, but with different const-ness. If c/b/u/v/o/omnibox_view_views.cc is compiled with UNIT_TEST set, it attempts to use the guarded member function instead of the base class which fails to compile. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/secondary/testing/gtest/BUILD.gn View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
In gyp the UNIT_TEST define is set for direct dependents hee: https://code.google.com/p/chromium/codesearch#chromium/src/testing/gtest.gyp&q=gtest.gyp&sq=package:chromium&type=cs&l=192
6 years, 4 months ago (2014-08-12 05:53:29 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-12 05:55:08 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-12 05:56:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/464503003/1
6 years, 4 months ago (2014-08-12 05:56:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 07:48:54 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 15:45:25 UTC) #6
Message was sent while issue was closed.
Change committed as 288988

Powered by Google App Engine
This is Rietveld 408576698