DescriptionGN: Only define UNIT_TEST in direct gtest deps
This matches the gyp build and is important for parts of the code that
guard their API with UNIT_TEST. For instance,
chrome/browser/ui/views/omnibox/omnibox_view_views.h has a GetRenderText
function guarded by #if UNIT_TEST that shadows a protected function
GetRenderText from its parent class views::Textfield, but with different
const-ness. If c/b/u/v/o/omnibox_view_views.cc is compiled with UNIT_TEST
set, it attempts to use the guarded member function instead of the base
class which fails to compile.
R=brettw@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288988
Patch Set 1 #
Messages
Total messages: 6 (0 generated)
|