Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2975)

Unified Diff: build/secondary/testing/gtest/BUILD.gn

Issue 464503003: GN: Only define UNIT_TEST in direct gtest deps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/testing/gtest/BUILD.gn
diff --git a/build/secondary/testing/gtest/BUILD.gn b/build/secondary/testing/gtest/BUILD.gn
index eb8604dc153a183b5b44ca925f2a066d7758ac58..f7c1e0d7208c9e49f7dc652d03800293de449f11 100644
--- a/build/secondary/testing/gtest/BUILD.gn
+++ b/build/secondary/testing/gtest/BUILD.gn
@@ -9,7 +9,6 @@ config("gtest_config") {
]
defines = [
- "UNIT_TEST",
# In order to allow regex matches in gtest to be shared between Windows
# and other systems, we tell gtest to always use it's internal engine.
@@ -54,6 +53,11 @@ config("gtest_config") {
}
}
+config("gtest_direct_config") {
+ visibility = ":*"
+ defines = [ "UNIT_TEST" ]
+}
+
static_library("gtest") {
sources = [
"include/gtest/gtest-death-test.h",
@@ -100,6 +104,7 @@ static_library("gtest") {
include_dirs = [ "." ]
all_dependent_configs = [ ":gtest_config" ]
+ direct_dependent_configs = [ ":gtest_direct_config" ]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698