Adding logging of offstore extensions state to user metrics.

chrome/browser/extensions/install_verifier.h

Index: chrome/browser/extensions/install_verifier.h
diff --git a/chrome/browser/extensions/install_verifier.h b/chrome/browser/extensions/install_verifier.h
index 47b44077842a9e1b5e1f2cb670a20fdcf4da22a8..8b9a1d99f476a02dd0b8cd2f14849ac2dd427e5c 100644
--- a/chrome/browser/extensions/install_verifier.h
+++ b/chrome/browser/extensions/install_verifier.h
@@ -57,7 +57,14 @@ class InstallVerifier : public ManagementPolicy::Provider {
 
   // Returns true if |id| is either verified or our stored signature explicitly
   // tells us that it was invalid when we asked the server about it.
-  bool IsKnownId(const std::string& id);
+  bool IsKnownId(const std::string& id) const;
+
+  // Returns whether the given |id| is included in our verified signature.
+  bool IsVerified(const std::string& id) const;

[Devlin, 2014/08/13 18:18:30]

Why does this need to be public?

[jwd, 2014/08/13 19:34:36]

Done.

+
+  // Returns whether the given |id| is considered invalid by our verified
+  // signature.
+  bool IsInvalid(const std::string& id) const;
 
   // Attempts to verify a single extension and add it to the verified list.
   void VerifyExtension(const std::string& extension_id);
@@ -73,6 +80,12 @@ class InstallVerifier : public ManagementPolicy::Provider {
   void Remove(const std::string& id);
   void RemoveMany(const ExtensionIdSet& ids);
 
+  // Returns whether an extension id is allowed by policy.
+  bool AllowedByEnterprisePolicy(const std::string& id) const;
+
+  // Determines if an extension claims to be from the webstore.
+  static bool FromStore(const Extension& extension);

[Devlin, 2014/08/13 18:18:30]

put static methods near the top of the class.

[jwd, 2014/08/13 19:34:36]

Done.

+
   // ManagementPolicy::Provider interface.
   virtual std::string GetDebugPolicyProviderName() const OVERRIDE;
   virtual bool MustRemainDisabled(const Extension* extension,
@@ -118,12 +131,6 @@ class InstallVerifier : public ManagementPolicy::Provider {
   // Removes any no-longer-installed ids, requesting a new signature if needed.
   void GarbageCollect();
 
-  // Returns whether an extension id is allowed by policy.
-  bool AllowedByEnterprisePolicy(const std::string& id) const;
-
-  // Returns whether the given |id| is included in our verified signature.
-  bool IsVerified(const std::string& id) const;
-
   // Returns true if the extension with |id| was installed later than the
   // timestamp of our signature.
   bool WasInstalledAfterSignature(const std::string& id) const;