Adding logging of offstore extensions state to user metrics.

chrome/browser/extensions/install_verifier.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_INSTALL_VERIFIER_H_
 #define CHROME_BROWSER_EXTENSIONS_INSTALL_VERIFIER_H_
 
 #include <queue>
 #include <set>
 #include <string>
@@ skipping 39 matching lines @@
 
   // Initializes this object for use, including reading preferences and
   // validating the stored signature.
   void Init();
 
   // Returns the timestamp of our InstallSignature, if we have one.
   base::Time SignatureTimestamp();
 
   // Returns true if |id| is either verified or our stored signature explicitly
   // tells us that it was invalid when we asked the server about it.
-  bool IsKnownId(const std::string& id);
+  bool IsKnownId(const std::string& id) const;
+
+  // Returns whether the given |id| is included in our verified signature.
+  bool IsVerified(const std::string& id) const;

[Devlin, 2014/08/13 18:18:30]

Why does this need to be public?

[jwd, 2014/08/13 19:34:36]

Done.

+
+  // Returns whether the given |id| is considered invalid by our verified
+  // signature.
+  bool IsInvalid(const std::string& id) const;
 
   // Attempts to verify a single extension and add it to the verified list.
   void VerifyExtension(const std::string& extension_id);
 
   // Attempts to verify all extensions.
   void VerifyAllExtensions();
 
   // Call this to add a set of ids that will immediately be considered allowed,
   // and kick off an aysnchronous request to Add.
   void AddProvisional(const ExtensionIdSet& ids);
 
   // Removes an id or set of ids from the verified list.
   void Remove(const std::string& id);
   void RemoveMany(const ExtensionIdSet& ids);
 
+  // Returns whether an extension id is allowed by policy.
+  bool AllowedByEnterprisePolicy(const std::string& id) const;
+
+  // Determines if an extension claims to be from the webstore.
+  static bool FromStore(const Extension& extension);

[Devlin, 2014/08/13 18:18:30]

put static methods near the top of the class.

[jwd, 2014/08/13 19:34:36]

Done.

+
   // ManagementPolicy::Provider interface.
   virtual std::string GetDebugPolicyProviderName() const OVERRIDE;
   virtual bool MustRemainDisabled(const Extension* extension,
                                   Extension::DisableReason* reason,
                                   base::string16* error) const OVERRIDE;
 
  private:
   // We keep a list of operations to the current set of extensions.
   enum OperationType {
     ADD_SINGLE,         // Adding a single extension to be verified.
@@ skipping 25 matching lines @@
   // Try adding a new set of |ids| to the list of verified ids.
   void AddMany(const ExtensionIdSet& ids, OperationType type);
 
   // Record the result of the verification for the histograms, and notify the
   // ExtensionPrefs if we verified all extensions.
   void OnVerificationComplete(bool success, OperationType type);
 
   // Removes any no-longer-installed ids, requesting a new signature if needed.
   void GarbageCollect();
 
-  // Returns whether an extension id is allowed by policy.
-  bool AllowedByEnterprisePolicy(const std::string& id) const;
-
-  // Returns whether the given |id| is included in our verified signature.
-  bool IsVerified(const std::string& id) const;
-
   // Returns true if the extension with |id| was installed later than the
   // timestamp of our signature.
   bool WasInstalledAfterSignature(const std::string& id) const;
 
   // Begins the process of fetching a new signature, based on applying the
   // operation at the head of the queue to the current set of ids in
   // |signature_| (if any) and then sending a request to sign that.
   void BeginFetch();
 
   // Saves the current value of |signature_| to the prefs;
@@ skipping 25 matching lines @@
   ExtensionIdSet provisional_;
 
   base::WeakPtrFactory<InstallVerifier> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(InstallVerifier);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_INSTALL_VERIFIER_H_