Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 464403003: Revert 289489 "Ensure there's no layout pending before accessing..." (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 289489 "Ensure there's no layout pending before accessing..." accessibility/deleting-iframe-destroys-axcache.html started to fail after this CL. http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/20592 > Ensure there's no layout pending before accessing WebAXObject from TestRunner. > > It's not safe to call WebAXObject functions when there's a layout pending. > Chrome never does this, it only calls WebAXObject from > renderer_accessibility_complete, and it makes sure to update layout before > accessing the accessibility tree. > > TestRunner didn't have the same protections, so this just explicitly updates > the layout before any accessibility call. > > BUG=393829 > > Review URL: https://codereview.chromium.org/469803003 TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -143 lines) Patch
M trunk/src/content/shell/renderer/test_runner/web_ax_object_proxy.cc View 10 chunks +83 lines, -143 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
6 years, 4 months ago (2014-08-14 10:54:05 UTC) #1
haraken
6 years, 4 months ago (2014-08-14 10:54:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r289515 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698