Source/bindings/scripts/idl_definitions.py - Issue 464273003: Restructure handling of list type extended attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/idl_definitions.py

Issue 464273003: Restructure handling of list type extended attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: minor fixes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/idl_definitions.py

diff --git a/Source/bindings/scripts/idl_definitions.py b/Source/bindings/scripts/idl_definitions.py

index 6a2a85c3abd598f0b1ad8ce55be59210f2a12558..ee7158ab663cde7578524829e76c38e02088f376 100644

--- a/Source/bindings/scripts/idl_definitions.py

+++ b/Source/bindings/scripts/idl_definitions.py

@@ -637,13 +637,14 @@ def ext_attributes_node_to_extended_attributes(idl_name, node):

"""

Returns:

Dictionary of {ExtAttributeName: ExtAttributeValue}.

- Value is usually a string, with three exceptions:

+ Value is usually a string, with these exceptions:

Constructors: value is a list of Arguments nodes, corresponding to

possible signatures of the constructor.

CustomConstructors: value is a list of Arguments nodes, corresponding to

possible signatures of the custom constructor.

NamedConstructor: value is a Call node, corresponding to the single

signature of the named constructor.

+ SetWrapperReferenceTo: value is an Arguments node.

"""

# Primarily just make a dictionary from the children.

# The only complexity is handling various types of constructors:

« no previous file with comments | « Source/bindings/scripts/blink_idl_parser.py ('k') | Source/bindings/scripts/idl_validator.py » ('j') | no next file with comments »